Add emitter:go and linter labels#4732
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lirenhe
requested review from
bterlson,
markcowl and
timotheeguerin
as code owners
Contributor
|
No changes needing a change description found. |
Contributor
⚡ Benchmark Results
Full details – comparing
|
| Metric | Baseline | Current | Change |
|---|---|---|---|
| total | 🔴 675.6ms | 🔴 667.8ms | -1.2% |
| loader | 🟢 155.1ms | 🟡 246.6ms | +59.0% 🔴 |
| resolver | 🟢 19.1ms | 🟢 15.8ms | -17.4% 🟢 |
| checker | 🟡 214.2ms | 🟡 201.2ms | -6.1% 🟢 |
| validation | 🟢 50.5ms | 🟢 45.3ms | -10.4% 🟢 |
| ↳ validation/@azure-tools/typespec-azure-core | 🟢 7.2ms | 🟢 7.1ms | -0.5% |
| ↳ validation/@typespec/http | 🟢 7.6ms | 🟢 5.9ms | -21.8% 🟢 |
| ↳ validation/@typespec/rest | 🟢 0.8ms | 🟢 0.5ms | -45.4% |
| ↳ validation/@typespec/versioning | 🔴 32.2ms | 🔴 30.1ms | -6.6% 🟢 |
| ↳ validation/compiler | 🟢 1.8ms | 🟢 1.4ms | -23.1% |
| linter | 🟢 168.5ms | 🟢 151.2ms | -10.3% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-core/auth-required | 🟢 0.0ms | 🟢 0.0ms | -34.9% |
| ↳ linter/@azure-tools/typespec-azure-core/bad-record-type | 🟢 0.3ms | 🟢 0.2ms | -27.1% |
| ↳ linter/@azure-tools/typespec-azure-core/byos | 🟢 6.9ms | 🟢 6.2ms | -10.7% |
| ↳ linter/@azure-tools/typespec-azure-core/casing-style | 🟢 0.7ms | 🟢 0.7ms | +0.2% |
| ↳ linter/@azure-tools/typespec-azure-core/composition-over-inheritance | 🟢 0.1ms | 🟢 0.1ms | -23.8% |
| ↳ linter/@azure-tools/typespec-azure-core/documentation-required | 🟢 1.0ms | 🟢 0.8ms | -18.3% |
| ↳ linter/@azure-tools/typespec-azure-core/friendly-name | 🟢 0.8ms | 🟢 0.6ms | -24.0% |
| ↳ linter/@azure-tools/typespec-azure-core/key-visibility-required | 🟢 0.2ms | 🟢 0.2ms | -13.5% |
| ↳ linter/@azure-tools/typespec-azure-core/known-encoding | 🟢 0.3ms | 🟢 0.3ms | +1.3% |
| ↳ linter/@azure-tools/typespec-azure-core/long-running-polling-operation-required | 🟢 0.4ms | 🟢 0.3ms | -12.9% |
| ↳ linter/@azure-tools/typespec-azure-core/no-case-mismatch | 🟢 0.3ms | 🟢 0.2ms | -16.6% |
| ↳ linter/@azure-tools/typespec-azure-core/no-closed-literal-union | 🟢 0.4ms | 🟢 0.2ms | -39.3% |
| ↳ linter/@azure-tools/typespec-azure-core/no-enum | 🟢 0.1ms | 🟢 0.0ms | -26.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-error-status-codes | 🟢 0.1ms | 🟢 0.1ms | -15.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-explicit-routes-resource-ops | 🟢 0.1ms | 🟢 0.1ms | -25.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-format | 🟢 0.7ms | 🟢 0.6ms | -18.6% |
| ↳ linter/@azure-tools/typespec-azure-core/no-generic-numeric | 🟢 0.5ms | 🟢 0.4ms | -20.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-header-explode | 🔴 21.7ms | 🔴 21.2ms | -2.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-legacy-usage | 🟢 1.2ms | 🟢 1.2ms | +0.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-multiple-discriminator | 🟢 0.1ms | 🟢 0.1ms | -15.6% |
| ↳ linter/@azure-tools/typespec-azure-core/no-nullable | 🟢 0.3ms | 🟢 0.3ms | -18.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-offsetdatetime | 🟢 1.3ms | 🟢 1.2ms | -7.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-openapi | 🟢 2.3ms | 🟢 2.0ms | -14.9% |
| ↳ linter/@azure-tools/typespec-azure-core/no-private-usage | 🟢 2.4ms | 🟢 1.9ms | -20.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-query-explode | 🔴 23.9ms | 🔴 22.8ms | -4.4% |
| ↳ linter/@azure-tools/typespec-azure-core/no-response-body | 🔴 26.8ms | 🔴 25.3ms | -5.5% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-core/no-rest-library-interfaces | 🟢 0.0ms | 🟢 0.0ms | -38.4% |
| ↳ linter/@azure-tools/typespec-azure-core/no-route-parameter-name-mismatch | 🟢 5.5ms | 🟢 5.6ms | +1.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-rpc-path-params | 🟢 0.2ms | 🟢 0.2ms | -6.6% |
| ↳ linter/@azure-tools/typespec-azure-core/no-string-discriminator | 🟢 0.1ms | 🟢 0.0ms | -21.8% |
| ↳ linter/@azure-tools/typespec-azure-core/no-unknown | 🟢 0.2ms | 🟢 0.2ms | -11.9% |
| ↳ linter/@azure-tools/typespec-azure-core/no-unnamed-union | 🟢 0.5ms | 🟢 0.3ms | -30.5% |
| ↳ linter/@azure-tools/typespec-azure-core/operation-missing-api-version | 🟢 0.2ms | 🟢 0.2ms | -38.3% |
| ↳ linter/@azure-tools/typespec-azure-core/request-body-problem | 🟢 0.3ms | 🟢 0.3ms | -13.4% |
| ↳ linter/@azure-tools/typespec-azure-core/require-versioned | 🟢 0.0ms | 🟢 0.0ms | -52.1% |
| ↳ linter/@azure-tools/typespec-azure-core/response-schema-problem | 🔴 25.5ms | 🔴 24.0ms | -5.7% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-core/rpc-operation-request-body | 🟢 0.3ms | 🟢 0.3ms | +3.1% |
| ↳ linter/@azure-tools/typespec-azure-core/spread-discriminated-model | 🟢 0.3ms | 🟢 0.3ms | -7.4% |
| ↳ linter/@azure-tools/typespec-azure-core/use-standard-names | 🟢 7.0ms | 🟢 5.6ms | -20.1% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-core/use-standard-operations | 🟢 0.2ms | 🟢 0.1ms | -19.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-child-resources | 🟢 4.9ms | 🟢 5.0ms | +2.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-lifecycle-operations | 🟢 0.0ms | 🟢 0.0ms | -20.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-common-types-version | 🟢 4.9ms | 🟢 4.6ms | -5.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key | 🟢 0.1ms | 🟢 0.1ms | -4.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage | 🟢 0.1ms | 🟢 0.1ms | -11.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes | 🟢 2.1ms | 🟢 1.2ms | -40.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-path-casing-conflicts | 🔴 27.7ms | 🟢 5.3ms | -81.0% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-record | 🟢 0.4ms | 🟢 0.4ms | -2.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes | 🟢 0.5ms | 🟢 0.5ms | -3.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes | 🟢 0.0ms | 🟢 0.0ms | -50.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-action-no-segment | 🟢 0.3ms | 🟢 0.2ms | -26.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-duplicate-property | 🟢 0.1ms | 🟢 0.1ms | +2.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-interface-requires-decorator | 🟢 0.0ms | 🟢 0.0ms | -34.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-action-verb | 🟢 0.1ms | 🟢 0.1ms | -31.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property | 🟢 0.1ms | 🟢 0.1ms | -18.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-version-format | 🟢 0.1ms | 🟢 0.0ms | -27.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-key-invalid-chars | 🟢 0.3ms | 🟢 0.3ms | +4.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-name-pattern | 🟢 0.0ms | 🟢 0.0ms | -47.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation | 🟢 0.2ms | 🟢 0.2ms | -26.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation-response | 🟢 5.7ms | 🟢 5.3ms | -6.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-patch | 🟢 0.4ms | 🟢 0.3ms | -17.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-path-segment-invalid-chars | 🟢 0.2ms | 🟢 0.2ms | -7.4% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state | 🟢 0.1ms | 🟢 0.1ms | -20.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/beyond-nesting-levels | 🟢 0.1ms | 🟢 0.1ms | -13.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/empty-updateable-properties | 🟢 0.2ms | 🟢 0.2ms | +7.3% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/improper-subscription-list-operation | 🟢 0.0ms | 🟢 0.0ms | -42.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/lro-location-header | 🟡 14.9ms | 🟡 15.0ms | +0.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-operations-endpoint | 🟢 0.0ms | 🟢 0.0ms | -37.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-x-ms-identifiers | 🟢 0.4ms | 🟢 0.3ms | -21.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-empty-model | 🟢 0.1ms | 🟢 0.1ms | -6.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-override-props | 🟢 0.1ms | 🟢 0.1ms | -22.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation | 🟢 0.2ms | 🟢 0.2ms | -6.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-response-body | 🔴 23.5ms | 🔴 22.4ms | -4.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/patch-envelope | 🟢 0.2ms | 🟢 0.2ms | +6.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/resource-name | 🟢 0.2ms | 🟢 0.2ms | +1.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/secret-prop | 🟢 8.4ms | 🟢 2.1ms | -74.3% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/unsupported-type | 🟢 0.4ms | 🟢 0.4ms | -3.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/version-progression | 🟢 0.0ms | 🟢 0.0ms | -29.7% |
| ↳ linter/@azure-tools/typespec-client-generator-core/property-name-conflict | 🟢 1.3ms | 🟢 1.1ms | -11.1% |
| ↳ linter/@azure-tools/typespec-client-generator-core/require-client-suffix | 🟢 0.3ms | 🟢 0.2ms | -40.0% |
| emit | 🔴 5.77s | 🔴 5.74s | -0.6% |
| ↳ emit/@azure-tools/typespec-autorest | 🟢 185.1ms | 🟢 165.6ms | -10.5% 🟢 |
| ↳ emit/@azure-tools/typespec-python | 🔴 4.32s | 🔴 4.41s | +2.0% |
| ↳ emit/@typespec/http-client-js | 🔴 1.06s | 🔴 1.01s | -4.1% |
| ↳ emit/@typespec/openapi3 | 🟢 163.9ms | 🟢 149.8ms | -8.6% 🟢 |
| ↳ emit/@typespec/openapi3/compute | 🟢 143.4ms | 🟢 133.3ms | -7.0% 🟢 |
| ↳ emit/@typespec/openapi3/write | 🟢 20.3ms | 🟢 16.0ms | -20.9% 🟢 |
Averaged across 3 specs (azure-arm-resource-manager, azure-core-dataplane, azure-full).
Threshold: changes > ±5% are highlighted.
🟢 Fast · 🟡 Moderate (stages >200ms, rules >10ms) · 🔴 Slow (stages >400ms, rules >20ms)
Contributor
|
You can try these changes here
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…java labels Co-authored-by: lirenhe <9100546+lirenhe@users.noreply.github.com>
Contributor
Merge conflicts resolved in commit |
timotheeguerin
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds new area labels for our work related to Go emitter and linter rules. Regenerates the label policy files via
pnpm sync-labels:#957300as other emitter labels).Files changed
eng/config/labels.ts— declare the two labels; maplinterto linter rule source directories across projects..github/policies/prs.triage.generated.yml,.github/policies/issues.triage.generated.yml— regenerated.CONTRIBUTING.md— regenerated labels table.Linter label path mappings
The
linterlabel is automatically applied to PRs that modify files under:packages/typespec-azure-core/src/rules/packages/typespec-azure-resource-manager/src/rules/packages/typespec-client-generator-core/src/rules/Follows #4557 / #4562.