Replace deprecated pipeline tasks (NodeTool@0, AzureCLI@1)#4815
Merged
Conversation
- NodeTool@0 (Node.js tool installer) -> UseNode@1 (input 'version' instead of 'versionSpec') in install.yml. - AzureCLI@1 -> AzureCLI@2 (adding the required 'scriptType: bash') in build-for-publish.yml (bundled packages + Azure playground) and pr-tools.yml (PR playground + website). No behavior change; silences the pipeline deprecation warnings.
Contributor
|
No changes needing a change description found. |
Contributor
|
You can try these changes here
|
Contributor
⚡ Benchmark Results
Full details – comparing
|
| Metric | Baseline | Current | Change |
|---|---|---|---|
| total | 🔴 934.1ms | 🔴 933.7ms | -0.0% |
| loader | 🟡 281.0ms | 🟡 279.5ms | -0.5% |
| resolver | 🟢 36.5ms | 🟢 38.3ms | +4.8% |
| checker | 🟡 333.0ms | 🟡 334.6ms | +0.5% |
| validation | 🟢 78.4ms | 🟢 82.1ms | +4.8% |
| ↳ validation/@azure-tools/typespec-azure-core | 🟡 11.4ms | 🟡 11.5ms | +0.9% |
| ↳ validation/@typespec/http | 🟡 13.8ms | 🟡 14.4ms | +4.1% |
| ↳ validation/@typespec/rest | 🟢 1.5ms | 🟢 1.4ms | -0.9% |
| ↳ validation/@typespec/versioning | 🔴 48.0ms | 🔴 51.0ms | +6.4% 🔴 |
| ↳ validation/compiler | 🟢 3.5ms | 🟢 3.7ms | +4.1% |
| linter | 🟢 198.8ms | 🟢 198.7ms | -0.1% |
| ↳ linter/@azure-tools/typespec-azure-core/auth-required | 🟢 0.1ms | 🟢 0.1ms | +2.2% |
| ↳ linter/@azure-tools/typespec-azure-core/bad-record-type | 🟢 0.5ms | 🟢 0.6ms | +9.0% |
| ↳ linter/@azure-tools/typespec-azure-core/byos | 🟢 7.8ms | 🟢 7.8ms | -0.3% |
| ↳ linter/@azure-tools/typespec-azure-core/casing-style | 🟢 1.3ms | 🟢 1.4ms | +4.6% |
| ↳ linter/@azure-tools/typespec-azure-core/composition-over-inheritance | 🟢 0.2ms | 🟢 0.2ms | +3.1% |
| ↳ linter/@azure-tools/typespec-azure-core/documentation-required | 🟢 1.8ms | 🟢 1.8ms | +2.9% |
| ↳ linter/@azure-tools/typespec-azure-core/friendly-name | 🟢 1.3ms | 🟢 1.3ms | +3.6% |
| ↳ linter/@azure-tools/typespec-azure-core/key-visibility-required | 🟢 0.3ms | 🟢 0.3ms | +2.9% |
| ↳ linter/@azure-tools/typespec-azure-core/known-encoding | 🟢 0.4ms | 🟢 0.5ms | +2.5% |
| ↳ linter/@azure-tools/typespec-azure-core/long-running-polling-operation-required | 🟢 0.7ms | 🟢 0.8ms | +5.4% |
| ↳ linter/@azure-tools/typespec-azure-core/no-case-mismatch | 🟢 0.6ms | 🟢 0.6ms | +2.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-closed-literal-union | 🟢 0.9ms | 🟢 0.9ms | +5.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-enum | 🟢 0.2ms | 🟢 0.2ms | +7.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-error-status-codes | 🟢 0.3ms | 🟢 0.3ms | +7.0% |
| ↳ linter/@azure-tools/typespec-azure-core/no-explicit-routes-resource-ops | 🟢 0.2ms | 🟢 0.2ms | +1.8% |
| ↳ linter/@azure-tools/typespec-azure-core/no-format | 🟢 0.8ms | 🟢 0.8ms | +0.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-generic-numeric | 🟢 0.8ms | 🟢 0.8ms | +2.8% |
| ↳ linter/@azure-tools/typespec-azure-core/no-header-explode | 🔴 24.6ms | 🔴 24.0ms | -2.6% |
| ↳ linter/@azure-tools/typespec-azure-core/no-legacy-usage | 🟢 1.8ms | 🟢 2.0ms | +7.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-multiple-discriminator | 🟢 0.2ms | 🟢 0.2ms | -1.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-nullable | 🟢 0.4ms | 🟢 0.4ms | -1.8% |
| ↳ linter/@azure-tools/typespec-azure-core/no-offsetdatetime | 🟢 1.8ms | 🟢 1.8ms | +1.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-openapi | 🟢 2.2ms | 🟢 2.2ms | +1.0% |
| ↳ linter/@azure-tools/typespec-azure-core/no-private-usage | 🟢 2.9ms | 🟢 3.0ms | +3.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-query-explode | 🔴 25.9ms | 🔴 25.0ms | -3.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-response-body | 🔴 31.1ms | 🔴 30.7ms | -1.0% |
| ↳ linter/@azure-tools/typespec-azure-core/no-rest-library-interfaces | 🟢 0.1ms | 🟢 0.1ms | +1.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-route-parameter-name-mismatch | 🟢 7.1ms | 🟢 6.9ms | -2.6% |
| ↳ linter/@azure-tools/typespec-azure-core/no-rpc-path-params | 🟢 0.4ms | 🟢 0.4ms | +0.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-string-discriminator | 🟢 0.1ms | 🟢 0.1ms | +1.9% |
| ↳ linter/@azure-tools/typespec-azure-core/no-unknown | 🟢 0.3ms | 🟢 0.3ms | -0.4% |
| ↳ linter/@azure-tools/typespec-azure-core/no-unnamed-union | 🟢 0.7ms | 🟢 0.7ms | +2.7% |
| ↳ linter/@azure-tools/typespec-azure-core/operation-missing-api-version | 🟢 0.3ms | 🟢 0.4ms | +5.3% |
| ↳ linter/@azure-tools/typespec-azure-core/request-body-problem | 🟢 0.4ms | 🟢 0.4ms | +0.9% |
| ↳ linter/@azure-tools/typespec-azure-core/require-versioned | 🟢 0.1ms | 🟢 0.1ms | +7.2% |
| ↳ linter/@azure-tools/typespec-azure-core/response-schema-problem | 🔴 30.3ms | 🔴 30.3ms | +0.0% |
| ↳ linter/@azure-tools/typespec-azure-core/rpc-operation-request-body | 🟢 0.6ms | 🟢 0.6ms | +2.7% |
| ↳ linter/@azure-tools/typespec-azure-core/spread-discriminated-model | 🟢 0.4ms | 🟢 0.4ms | +0.2% |
| ↳ linter/@azure-tools/typespec-azure-core/use-standard-names | 🟢 7.1ms | 🟢 6.9ms | -2.6% |
| ↳ linter/@azure-tools/typespec-azure-core/use-standard-operations | 🟢 0.2ms | 🟢 0.2ms | +4.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-child-resources | 🟡 18.3ms | 🟡 17.9ms | -1.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-lifecycle-operations | 🟢 0.2ms | 🟢 0.2ms | +3.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-common-types-version | 🟡 10.8ms | 🟡 11.5ms | +6.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key | 🟢 0.2ms | 🟢 0.2ms | +2.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage | 🟢 0.1ms | 🟢 0.1ms | +4.3% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes | 🟢 5.1ms | 🟡 10.5ms | +106.8% 🔴 |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-path-casing-conflicts | 🟡 15.1ms | 🟡 16.8ms | +11.0% 🔴 |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-record | 🟢 0.6ms | 🟢 0.6ms | +0.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes | 🟢 1.3ms | 🟢 1.3ms | -1.3% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes | 🟢 0.2ms | 🟢 0.2ms | +29.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-action-no-segment | 🟢 0.4ms | 🟢 0.4ms | +3.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-duplicate-property | 🟢 0.3ms | 🟢 0.3ms | +0.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-interface-requires-decorator | 🟢 0.1ms | 🟢 0.1ms | +20.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-action-verb | 🟢 0.1ms | 🟢 0.1ms | +4.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property | 🟢 0.2ms | 🟢 0.2ms | +2.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-version-format | 🟢 0.2ms | 🟢 0.2ms | +7.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-key-invalid-chars | 🟢 0.4ms | 🟢 0.5ms | +4.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-name-pattern | 🟢 0.1ms | 🟢 0.1ms | +4.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation | 🟢 0.5ms | 🟢 0.5ms | +4.4% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation-response | 🟢 8.2ms | 🟢 8.3ms | +1.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-patch | 🟢 0.8ms | 🟢 0.8ms | +3.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-path-segment-invalid-chars | 🟢 0.4ms | 🟢 0.4ms | +3.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state | 🟢 0.4ms | 🟢 0.4ms | +4.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/beyond-nesting-levels | 🟢 0.2ms | 🟢 0.2ms | +1.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/empty-updateable-properties | 🟢 0.4ms | 🟢 0.4ms | +4.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/improper-subscription-list-operation | 🟢 0.1ms | 🟢 0.1ms | +1.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/lro-location-header | 🟡 18.1ms | 🟡 17.5ms | -3.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-operations-endpoint | 🟢 0.1ms | 🟢 0.1ms | +9.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-x-ms-identifiers | 🟢 0.9ms | 🟢 1.0ms | +7.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-empty-model | 🟢 0.2ms | 🟢 0.2ms | -3.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-override-props | 🟢 0.3ms | 🟢 0.3ms | +10.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation | 🟢 0.4ms | 🟢 0.4ms | +1.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-response-body | 🔴 27.5ms | 🔴 26.5ms | -3.4% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/patch-envelope | 🟢 0.4ms | 🟢 0.4ms | +1.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/resource-name | 🟢 0.4ms | 🟢 0.4ms | +3.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/secret-prop | 🟢 4.9ms | 🟢 5.2ms | +6.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/unsupported-type | 🟢 0.6ms | 🟢 0.6ms | +2.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/version-progression | 🟢 0.3ms | 🟢 0.3ms | +12.1% |
| ↳ linter/@azure-tools/typespec-client-generator-core/property-name-conflict | 🟢 2.1ms | 🟢 2.2ms | +5.3% |
| ↳ linter/@azure-tools/typespec-client-generator-core/require-client-suffix | 🟢 1.4ms | 🟢 1.6ms | +10.7% |
| emit | 🔴 5.80s | 🔴 5.61s | -3.4% |
| ↳ emit/@Azure-Tools | 🟢 0.0ms | 🟢 0.0ms | +0.0% |
| ↳ emit/@azure-tools/typespec-autorest | 🟢 116.0ms | 🟢 115.6ms | -0.3% |
| ↳ emit/@azure-tools/typespec-python | 🔴 2.18s | 🔴 2.09s | -3.9% |
| ↳ emit/@typespec | 🟢 0.0ms | 🟢 0.0ms | +0.0% |
| ↳ emit/@typespec/http-client-js | 🔴 539.1ms | 🔴 530.9ms | -1.5% |
| ↳ emit/@typespec/openapi3 | 🟢 100.4ms | 🟢 99.2ms | -1.1% |
| ↳ emit/@typespec/openapi3/compute | 🟢 87.2ms | 🟢 85.9ms | -1.6% |
| ↳ emit/@typespec/openapi3/write | 🟢 12.9ms | 🟢 13.1ms | +1.5% |
Averaged across 3 specs (azure-arm-resource-manager, azure-core-dataplane, azure-full).
Threshold: changes > ±5% are highlighted.
🟢 Fast · 🟡 Moderate (stages >200ms, rules >10ms) · 🔴 Slow (stages >400ms, rules >20ms)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silences the 1ES/pipeline deprecation warnings:
NodeTool@0("Node.js tool installer", deprecated) →UseNode@1(UseNodeV1) ininstall.yml. InputversionSpec→version(both accept a version spec like24.16.0).AzureCLI@1(deprecated) →AzureCLI@2inbuild-for-publish.yml(bundled packages + Azure playground) andpr-tools.yml(PR playground + website), adding the now-requiredscriptType: bash.No behavior change.