Skip to content

[Documentation] Add missing "Implicit Flow vs Authorization Code Flow with PKCE" section to MSAL Browser README #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Jul 3, 2025

This PR fixes a missing documentation section in the MSAL Browser README that was referenced in the table of contents but didn't exist in the document.

Issue

The MSAL Browser README.md had:

  • A table of contents entry for "Authorization Code vs Implicit" linking to #implicit-flow-vs-authorization-code-flow-with-pkce
  • An inline reference in the "About" section pointing to the same anchor
  • But no actual section with that heading existed, causing broken links

Solution

Added the missing section "## Implicit Flow vs Authorization Code Flow with PKCE" that includes:

Content Added

  • Authorization Code Flow with PKCE explanation: Details about the current OAuth 2.0 flow used by MSAL.js 2.x and its security benefits
  • Implicit Flow (Deprecated) explanation: Information about the previous flow used in MSAL.js 1.x and why it's deprecated
  • Migration Considerations: Guidance for developers migrating from v1.x to v2.x
  • References to additional documentation: Links to migration guides and Microsoft identity platform docs

Section Structure

## Implicit Flow vs Authorization Code Flow with PKCE

### Authorization Code Flow with PKCE
- Enhanced Security
- No Tokens in URLs
- Refresh Token Support
- OIDC Compliance

### Implicit Flow (Deprecated)
- Security concerns outlined
- Reasons for deprecation

### Migration Considerations
- Configuration requirements
- Migration guidance

The section is properly positioned between "Build and Test" and "Framework Wrappers" as indicated by the table of contents order.

Fixes #7347.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] [Documentation] Missing Section: "Authorization code vs. Implicit" [Documentation] Add missing "Implicit Flow vs Authorization Code Flow with PKCE" section to MSAL Browser README Jul 3, 2025
@Copilot Copilot AI requested a review from tnorling July 3, 2025 19:24
Copilot finished work on behalf of tnorling July 3, 2025 19:24
@Copilot Copilot AI requested a review from tnorling July 3, 2025 19:32
Copilot finished work on behalf of tnorling July 3, 2025 19:32
@tnorling tnorling marked this pull request as ready for review July 3, 2025 21:29
@github-actions github-actions bot added documentation Related to documentation. msal-browser Related to msal-browser package labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-browser Related to msal-browser package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Missing Section: "Authorization code vs. Implicit"
3 participants