Lozensky/add fmi path - #3247
Merged
Merged
Conversation
JLoze (JoshLozensky)
marked this pull request as draft
February 19, 2025 00:20
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
Jean-Marc Prieur (jmprieur)
left a comment
Collaborator
There was a problem hiding this comment.
This is a great start
JLoze (JoshLozensky)
marked this pull request as ready for review
February 19, 2025 21:13
SummarySummary
CoverageNo assemblies have been covered. |
Jean-Marc Prieur (jmprieur)
approved these changes
Feb 19, 2025
Jean-Marc Prieur (jmprieur)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Thanks, JLoze (@JoshLozensky)
Kelly🌠 (kllysng)
approved these changes
Feb 20, 2025
This was referenced Jul 25, 2025
Closed
This was referenced Aug 1, 2025
This was referenced Apr 27, 2026
Merged
This was referenced May 4, 2026
Closed
Merged
This was referenced May 25, 2026
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For testing, will be working with Bogdan/Travis on E2E testing as this isn't really approachable via unit tests.
Since MSAL made
AcquireTokenForClient.WithFmiPath()available, in the one place we use the AcquireTokenForClient method, adding a check for and insertion of the FMI Path so Id Web customers can make use of this new functionality. Addresses issue #3240