ci(binskim): drop invalid 'suppressions' field on notifications#177
Merged
Conversation
…tions SARIF 2.1.0 disallows 'suppressions' on toolConfigurationNotifications (only allowed on results). Adding it caused GitHub's SARIF upload for binskim-go to fail with: 'instance.runs[0].invocations[0].toolConfigurationNotifications[0] is not allowed to have the additional property suppressions'. Move the audit-trail justification into the notification's message.text instead; the canonical record lives in binskim_suppressions.json. The level is still demoted to 'note' and executionSuccessful is still flipped to true when no error/warning notifications remain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #176 added a
suppressionsarray to demotedtoolConfigurationNotificationsfor audit-trail purposes, but SARIF 2.1.0 only allowssuppressionsonresultobjects, not on notifications. The binskim-go SARIF upload on the PR #176 merge commit (sha 26e00cb) failed with:This PR moves the justification text into the notification's
message.text(visible inline) and keeps the canonical audit record inbinskim_suppressions.json. Level demotion tonoteandexecutionSuccessful=trueflip are unchanged.Verified locally against the failed go SARIF — schema validates clean against the OASIS SARIF 2.1.0 JSON schema.