Adding pe update2#214
Open
iriaosara wants to merge 4 commits into
Open
Conversation
iriaosara
requested review from
TheovanKraay,
jaydestro and
sajeetharan
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the repository’s Cosmos DB guidance by adding a new security rule covering Private Endpoint DNS resolution pitfalls, and updates the compiled skill artifacts / supporting infrastructure so the guidance is surfaced to agents and testable via eval tasks.
Changes:
- Added a new “Private Endpoint DNS Resolution” rule to both
cosmosdb-securityandcosmosdb-best-practices, and updated the compiledAGENTS.mdoutputs accordingly. - Updated the compiler’s default section list and the code-review checklist to recognize
fts-andsecurity-rule prefixes (and include new sections in compiled output). - Added an eval task to validate the private endpoint DNS troubleshooting guidance.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/cosmosdb-security/rules/security-private-endpoint-dns.md | New security rule content for private endpoint DNS setup/troubleshooting (source rule). |
| skills/cosmosdb-security/AGENTS.md | Regenerated compiled output to include the new rule in the security skill. |
| skills/cosmosdb-best-practices/rules/security-private-endpoint-dns.md | Same new rule added to best-practices skill’s Security section (source rule). |
| skills/cosmosdb-best-practices/AGENTS.md | Regenerated compiled output; now includes FTS + Security sections and the new rule. |
| scripts/compile.js | Updated default sections to add fts- and security- categories. |
| evals/cosmosdb-best-practices/tasks/security-private-endpoint-dns.yaml | New eval task covering the private endpoint DNS failure mode prompt. |
| .github/skills/code-review/checklist.md | Updated valid rule prefixes and clarified eval-task tagging expectations for new categories. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Iria Osara <87394684+iriaosara@users.noreply.github.com>
Comment on lines
+62
to
+64
| { prefix: 'vector-', name: 'Vector Search', number: 11, impact: 'HIGH' }, | ||
| { prefix: 'fts-', name: 'Full-Text Search', number: 12, impact: 'HIGH' }, | ||
| { prefix: 'security-', name: 'Security', number: 13, impact: 'HIGH' } |
Comment on lines
+1
to
+6
| --- | ||
| title: Configure Private Endpoints with Correct DNS Resolution | ||
| impact: HIGH | ||
| impactDescription: client connectivity failure when public network access is disabled and DNS resolves to the public endpoint | ||
| tags: connectivity, private-endpoint, dns, vnet, security, portal | ||
| --- |
Contributor
|
@iriaosara there are some ongoing changes being evaluated to the structure that could require this to be modified. you'll definetely get notice when it's time to make any changes to avoid merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
npm run validateand it passednpm run buildto regenerate AGENTS.md (if adding/updating rules){prefix}-{description}.mdtitle,impact,tags)For New Rules
Rule file:
skills/cosmosdb-best-practices/rules/_____.mdCategory:
Impact level:
Why is this rule important?
Agent Testing
Related Issues
Additional Notes