Skip to content

Remove matrix strategy to fix version-suffixed check names#8

Merged
seesharprun merged 1 commit into
mainfrom
copilot/update-check-name-remove-version
Mar 18, 2026
Merged

Remove matrix strategy to fix version-suffixed check names#8
seesharprun merged 1 commit into
mainfrom
copilot/update-check-name-remove-version

Conversation

Copilot AI commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the workflow so version numbers are no longer appended to check names (e.g., Validate .NET Samples (10.0)Validate .NET Samples).

GitHub Actions automatically appends matrix values to a job's display name when a matrix strategy is used. Since each job only had a single version in its matrix, the matrix strategy wasn't providing any real benefit — it only caused the fragile version-suffixed check names.

Changes

  • Removed the matrix strategy block from all five validate jobs: Python, JavaScript/TypeScript, Java, .NET, and Go
  • Hardcoded the version values directly in each job's with: block (values unchanged)

…ck names

Co-authored-by: seesharprun <5067401+seesharprun@users.noreply.github.com>
@seesharprun seesharprun marked this pull request as ready for review March 18, 2026 18:43
Copilot AI review requested due to automatic review settings March 18, 2026 18:43
Copilot AI requested a review from seesharprun March 18, 2026 18:43
@seesharprun seesharprun merged commit 441a168 into main Mar 18, 2026
8 checks passed
@seesharprun seesharprun deleted the copilot/update-check-name-remove-version branch March 18, 2026 18:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the sample validation GitHub Actions workflow by removing version matrices and pinning each language validation job to a single, explicit runtime version.

Changes:

  • Removed strategy.matrix blocks for Python, Node.js, Java, .NET, and Go validation jobs.
  • Hardcoded runtime versions directly in each corresponding setup-* action configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: actions/setup-go@v6
with:
go-version: ${{ matrix.version }}
go-version: '1.23.0'
seesharprun added a commit that referenced this pull request Mar 18, 2026
…t folder (#7)

- [x] Add `.editorconfig` via `dotnet new editorconfig`
- [x] Replace `.gitignore` using `dotnet new gitignore`
- [x] Add `Directory.Packages.props` with floating major versions
- [x] Add `Directory.Build.props` with shared `UserSecretsId`
- [x] Simplify `Program.cs`: remove version pins and `UserSecretsId`
- [x] Remove comments from `Directory.Build.props` and
`Directory.Packages.props`
- [x] Resolve merge conflict with main: rename `Program.cs` →
`connect.cs`, add `Newtonsoft.Json@13.*` to packages
- [x] Sync with main (#8): remove matrix strategy and hardcode versions
in `validate.yml`

<!-- START COPILOT CODING AGENT TIPS -->
---

💬 Send tasks to Copilot coding agent from
[Slack](https://gh.io/cca-slack-docs) and
[Teams](https://gh.io/cca-teams-docs) to turn conversations into code.
Copilot posts an update in your thread when it's finished.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: seesharprun <5067401+seesharprun@users.noreply.github.com>
Co-authored-by: seesharprun <sidandrews@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants