Add Linux/macOS deployer script - #2
Open
alirahimi818 wants to merge 3 commits into
Open
Conversation
Bash equivalent of Deploy-Fastly-Windows.ps1 for Linux and macOS users. Requires: bash, curl, python3, openssl, npm.
There was a problem hiding this comment.
2 issues found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- P1: add HTTP status checking to add_fastly_backend and upload_fastly_package instead of silently discarding curl output - P2: download NodeSource setup script to temp file before sudo execution instead of piping directly to sudo bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a cross-platform Bash deployer for Linux/macOS with full Fastly Compute deploy/redeploy/manage flow and updated setup docs. Also hardens the installer with better curl error handling and a safer Node.js auto-install. This brings feature parity with the Windows installer.
New Features
@fastly/js-computeruntime is present before build.Bug Fixes
Written for commit 71c5c8a. Summary will update on new commits.