Making the design fully append only#252
Conversation
MonikaVo
left a comment
MonikaVo
left a comment
There was a problem hiding this comment.
When I run the code, it gives me some errors. I mentioned them in the comments and tried to describe my findings.
|
@MonikaVo I did the inital response to all your comments, and fixed the problematic errors. |
MonikaVo
left a comment
MonikaVo
left a comment
There was a problem hiding this comment.
I tested it again and had again some new issues. I added comments for these. Please let me know if you have a different point of view on these issues.
|
@MonikaVo Hi Monika, back to you :) |
only one logger and makes all the services use this logger. This avoids logging the same messages three times. The change in gitignore excludes the config file from git commits to avoid the accidential commit of the config file, which shall remain local.
MonikaVo
left a comment
MonikaVo
left a comment
There was a problem hiding this comment.
It seems that this works now. :)
|
@MonikaVo @SKS94 hi 👋 I'm working on a PREMISE deliverable involving FINALES (@MonikaVo is aware) and am running into a minor issue - the README instructions are broken? Specifically, |
|
Hi @edan-bainglass, I cannot test it at the moment, but could you please try to delete line 62 in https://github.com/BIG-MAP/FINALES2/blob/main/src/FINALES2/cli/devtest.py and check if it works then? Since this contains the |
Thanks @MonikaVo. That works 🙂 |
3 participants
To make the entire database design fully Append only, two tables tracking the is_active states of quantities and tenants are needed. This has been added to the database, and all the necessary changes to the internal sqlalchemy queries have been changed.
I have tested registration of tenants and capabilities, along with the de-registration cli. The endpoints for capabilities and tenants are also functioning as far as I can see.
The status field for requests and results were tracked indivually in tracking tables, but were still present in the main tables. This has been removed, and all necessary queries dealing with this has been updated