Skip to content

Editor View Only #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

alexottoboni
Copy link
Contributor

@alexottoboni alexottoboni commented Dec 21, 2016

The model preview is hidden when the ?editor URL parameter is given.
The editor then takes up the entire width of the screen.

#5

screen shot 2016-12-20 at 11 15 10 pm

The model preview is hidden when the `?editor` URL parameter is given.
The editor then takes up the entire width of the screen.
@BKcore
Copy link
Owner

BKcore commented Dec 23, 2016

Thanks for submitting this.
I'm in vacation until January, so I'll review this when I get back.
Happy holidays!

@@ -20,6 +20,8 @@ class App
@extend(@conf, conf)
@ui = new shdr.UI(@)
return if not @initViewer(domCanvas)
if window.location.search.substring(1) == 'editor'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check looks a bit dirty, imho )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants