Skip to content

Refactor output of phi on the particles #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2024
Merged

Refactor output of phi on the particles #4839

merged 2 commits into from
Apr 9, 2024

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Apr 9, 2024

This is a follow-up on #4599. As suggested in review comments, the function has been put in a separate .cpp file.

@RemiLehe RemiLehe requested a review from ax3l April 9, 2024 14:03
ax3l
ax3l approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ax3l
Copy link
Member

ax3l commented Apr 9, 2024

Azure was hanging

@ax3l ax3l closed this Apr 9, 2024
@ax3l ax3l reopened this Apr 9, 2024
@ax3l ax3l added cleaning Clean code, improve readability component: diagnostics all types of outputs labels Apr 9, 2024
@ax3l ax3l enabled auto-merge (squash) April 9, 2024 15:28
@ax3l ax3l merged commit 5640de3 into BLAST-WarpX:development Apr 9, 2024
79 checks passed
@grobertdautun grobertdautun mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
cleaning Clean code, improve readability component: diagnostics all types of outputs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemiLehe @ax3l