IA-3456 improve get or create for orgunit (duplicate on uuid)

[mestachs]

To minize duplicate and be "ready" when we will introduce the unique index

Related JIRA tickets : IA-3456

Self proofreading checklist

• Did I use eslint and black formatters
• Is my code clear enough and well documented
• Are my typescript files well typed
• New translations have been added or updated if new strings have been introduced in the frontend
• My migrations file are included
• Are there enough tests
• Documentation has been included (for new feature)

Doc

• Tell us where the doc can be found (docs folder, wiki, in the code...)

Changes

see #1652

How to test

see #1652
but the mobile unit test does that

for a more "real life" reproduction : https://gist.github.com/mestachs/2cc50bf310996d14cc48623a05d42caf

note that we have historical data so we will need an intermediate cleanup
create the a temporary index as in the _notes.md
then really cleanup "old data" and all environments (harder)

Print screen / video

Upload here print screens or videos showing the changes

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

[bramj]

I think it's possible to not have a default version on an account. I think that situation would probably blow up anyways, but not sure if we should consider it here 🤔

[mathvdh]

@beygorghor I think we already had to code special cases when there is no default_version so it can happen right ?

[beygorghor]

Yes indeed, the frontend allows no default version

[bramj]

Duplicate of line 347?

[mathvdh]

See comments from Bram, otherwise it seems ok to me

[mathvdh]

@beygorghor I think we already had to code special cases when there is no default_version so it can happen right ?

[bramj]

@mestachs In order to deblock this PR, do you think it would be a good idea to add a conditional unique index when the created_at is greater than today?

[bramj]

Conditional indexes to add manually on big servers:

CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS iaso_orgunit_uuid_version_idx_unicity_newer ON iaso_orgunit (uuid, version_id)
WHERE
	uuid IS NOT NULL AND version_id IS NOT NULL AND created_at >= '2025-01-14';

CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS iaso_entity_uuidx_unicity_newer ON iaso_entity (uuid)
WHERE
	uuid IS NOT NULL AND created_at >= '2025-01-14';

CREATE UNIQUE INDEX CONCURRENTLY IF NOT EXISTS iaso_instance_uuidx_unicity_newer ON iaso_instance (uuid)
WHERE
	uuid IS NOT NULL AND created_at >= '2025-01-14';

[bramj]

@mathvdh @madewulf @bmonjoie Do you see any issues with manually adding the indexes in my above comment?

Since UUIDs for instances and entities are generated on the mobile app I don't think they should be unique only per project or something like that. Making them real UUIDs feels like the best option to me. For org units we're enforcing uniqueness only per version since @mestachs discovered that import/export/reimport geopackage is putting the same UUID in 2 source versions.

[mathvdh]

@bramj I don't see any problem with it (except for duplicate line 350 as commented above). Is the plan to cleanup duplicate uuids and apply the index unconditionally after that ? Or what's the plan ?

[bramj]

@bramj I don't see any problem with it (except for duplicate line 350 as commented above). Is the plan to cleanup duplicate uuids and apply the index unconditionally after that ? Or what's the plan ?

Ideally, yes that would be the plan, but to be honest not sure how doable that is.