IA-3884: show groups version in dropdown #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating on-the-fly configuration to restrict OrgUnit Change Request creation, the `created_at` and `updated_at` dates were not set. This resulted in the backend sending `null` for those required field. Those fields are now set to the current date and time to fix the issue in the mobile app. IA-3878
- in change requests config - in group sets table - in most groups dropdowns
- this will prevent errors in the front end when using dropdowns
- Improve handling of anon users
- Keep only useGetGroupDropdown - add default source version to its API call
- Remove unused useGetGroups - Update useGetOrgUnitDetailData to use /groups/dropdown endpoint - Update org unit forms to use dropdown API response - remove unused utils - remove unused TS type - Correct error in SaveData TS type
quang-le
commented
Jan 22, 2025
Comment on lines
-199
to
-207
| const groupsInputComponent = useMemo(() => { | ||
| return createGroupsInputComponent({ | ||
| isFetchingGroups, | ||
| handleChange, | ||
| filters, | ||
| groups, | ||
| }); | ||
| }, [filters, groups, handleChange, isFetchingGroups]); | ||
|
|
There was a problem hiding this comment.
This was a hidden component. I took it out. It introduces some repetition, but is more legible I think, and avoids the unnecessary useMemo
Comment on lines
-44
to
-46
| settings.row.original.groups.sort((a, b) => | ||
| a.name > b.name ? 1 : b.name > a.name ? -1 : 0, | ||
| ); |
There was a problem hiding this comment.
The linter was complaining about the nested ternary
Comment on lines
+30
to
+37
| const groupsDataSourceQueryParams = originalOrgUnit?.source_id | ||
| ? `?dataSource=${originalOrgUnit.source_id}` | ||
| : undefined; | ||
| const groupsQueryParams = isNewOrgunit | ||
| ? '?defaultVersion=true' | ||
| : groupsDataSourceQueryParams; | ||
| const groupsApiUrl = '/api/groups/dropdown/'; | ||
|
|
There was a problem hiding this comment.
It's a bit of gymastic but:
- strings don't need to be memoized
- it allows me to pass just the params to the queryKey, so all group dropdown hooks have the same queryKey structure
7 tasks
quang-le
changed the title
beygorghor
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1933: use groups dropdown endpoint where indicated
Related JIRA tickets : IA-3880, IA-3884
Self proofreading checklist
Doc
Comments in the code
Changes
CampaignScope,RoundScopeandSubActivityScopenaming to avoid react key errors in the front-endHow to test
Test in the UI:
Print screen / video
Screen.Recording.2025-01-22.at.18.07.55.mov
Screen.Recording.2025-01-22.at.18.03.42.mov
Screen.Recording.2025-01-22.at.18.07.55.mov
Notes
Includes hotfixes v1.251a and v1.251b
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.