Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1838: add physical inventory vials removal #1950

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Feb 3, 2025

Users need to be able to reduce stock by adding incident reports of type physical inventory

Related JIRA tickets : POLIO-1838

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

NA

Changes

  • split PHYSICAL_INVENTORY into PHYSICAL_INVETORY_ADD and PHYSICAL_INVENTORY_REMOVE in IncidentReport.StockCorrectionChoices
  • migrate existing IncidentReport with PHYSICAL_INVENTORY to PHYSICAL_INVENTORY_ADD
  • Update VaccineCalculator get_list_of_usable_vials and get_list_of_unusable_vials
  • Update tests
  • Update dropdown options fort incident report
  • Add label to RadioGroup to make selection more explicit
  • Update translations

How to test

Go to vaccine Module > Stock management > stock variation
Create and edit Incident reports of type physical inventory add and remove

Print screen / video

Screen.Recording.2025-02-03.at.16.16.22.mov

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

- split PHYSICAL_INVENTORY into PHYSICAL_INVETORY_ADD and PHYSICAL_INVENTORY_REMOVE in IncidentReport.StockCorrectionChoices
- migrate existing IncidentReport with PHYSICAL_INVENTORY to PHYSICAL_INVENTORY_ADD
- Update VaccineCalculator get_list_of_usable_vials and get_list_of_unusable_vials
-Update tests
- Update dropdown options fort incident report
- Add label to RadioGroup to make selection more explicit
- Update translations
@beygorghor beygorghor added the release Should be released in production at next deploy label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Should be released in production at next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants