Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3980 Earmarked stocks make campaign and round selection not mandatory #2003

Conversation

mathvdh
Copy link
Collaborator

@mathvdh mathvdh commented Mar 4, 2025

Make the campaign and round optional when creating a Earmark, and add a "temporary campaign name" text field on the model and in the front.

Related JIRA tickets : IA-3980, IA-3982

Self proofreading checklist

  • Did I use eslint and ruff formatters?
  • Is my code clear enough and well documented?
  • Are my typescript files well typed?
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests?

Changes

make the "campaign" and "round" field optional on the EarmarkedStock model and add an optional "temporary_campaign_name" charfield on the same model.

Modify the APis for that.
Modify the frontend to reflect that as well.

How to test

Try to create a earmarked stock without campaign or round using the dashboard.

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@mathvdh mathvdh changed the title Ia 3980 earmarked stocks make obr name and round selection not mandatory IA-3980 Earmarked stocks make campaign and round selection not mandatory Mar 4, 2025
@mathvdh mathvdh marked this pull request as ready for review March 4, 2025 13:57
Copy link
Member

@quang-le quang-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it wouldn't be better to also have a temporary round. Maybe double-check this with PM.

Also there's a mean bug with the validation of the dialog:

Screen.Recording.2025-03-05.at.11.54.57.mov

@beygorghor beygorghor added the release Should be released in production at next deploy label Mar 6, 2025
@quang-le quang-le self-requested a review March 11, 2025 13:20
@mathvdh mathvdh merged commit ec9928c into main Mar 11, 2025
3 checks passed
@mathvdh mathvdh deleted the IA-3980-earmarked-stocks-make-obr-name-and-round-selection-not-mandatory branch March 11, 2025 14:03
@hakifran hakifran added user tested Has already been tested on staging ok for release Released and removed ok for release labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Should be released in production at next deploy Released user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants