-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3980 Earmarked stocks make campaign and round selection not mandatory #2003
Merged
mathvdh
merged 11 commits into
main
from
IA-3980-earmarked-stocks-make-obr-name-and-round-selection-not-mandatory
Mar 11, 2025
Merged
IA-3980 Earmarked stocks make campaign and round selection not mandatory #2003
mathvdh
merged 11 commits into
main
from
IA-3980-earmarked-stocks-make-obr-name-and-round-selection-not-mandatory
Mar 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:BLSQ/iaso into IA-3980-earmarked-stocks-make-obr-name-and-round-selection-not-mandatory
quang-le
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it wouldn't be better to also have a temporary round. Maybe double-check this with PM.
Also there's a mean bug with the validation of the dialog:
Screen.Recording.2025-03-05.at.11.54.57.mov
plugins/polio/js/src/domains/VaccineModule/StockManagement/StockVariation/Modals/validation.ts
Outdated
Show resolved
Hide resolved
…ocks-make-obr-name-and-round-selection-not-mandatory
quang-le
approved these changes
Mar 11, 2025
Co-authored-by: Math VDH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release
Should be released in production at next deploy
Released
user tested
Has already been tested on staging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the campaign and round optional when creating a Earmark, and add a "temporary campaign name" text field on the model and in the front.
Related JIRA tickets : IA-3980, IA-3982
Self proofreading checklist
Changes
make the "campaign" and "round" field optional on the EarmarkedStock model and add an optional "temporary_campaign_name" charfield on the same model.
Modify the APis for that.
Modify the frontend to reflect that as well.
How to test
Try to create a earmarked stock without campaign or round using the dashboard.
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.