Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1857: comment out earmarked stock code #2004

Conversation

quang-le
Copy link
Member

@quang-le quang-le commented Mar 4, 2025

What problem is this PR solving? Explain here in one sentence.

Related JIRA tickets : POLIO-1857

Self proofreading checklist

  • Did I use eslint and ruff formatters?
  • Is my code clear enough and well documented?
  • Are my typescript files well typed?
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests?
  • Documentation has been included (for new feature)

Doc

Changes

  • Comment out code related to earmarked stocks in vaccine stock details + summary

How to test

Explain how to test your PR.

Go to vaccine module> stock management --> Open a stock

Print screen / video

Screenshot 2025-03-04 at 16 36 27

Notes

This will impact dashboard stock exports

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

@beygorghor beygorghor added the release Should be released in production at next deploy label Mar 6, 2025
@beygorghor beygorghor self-assigned this Mar 6, 2025
@beygorghor beygorghor self-requested a review March 11, 2025 08:36
Copy link
Collaborator

@beygorghor beygorghor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having issue while trying to run your PR, this is maybe data related ?
Screenshot 2025-03-11 at 10 33 53

@quang-le quang-le changed the base branch from main to IA-3980-earmarked-stocks-make-obr-name-and-round-selection-not-mandatory March 11, 2025 11:16
@quang-le
Copy link
Member Author

…ion-not-mandatory' of github.com:BLSQ/iaso into POLIO-1857_hide_earmarked
Copy link
Collaborator

@mathvdh mathvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me.

@mathvdh mathvdh merged commit 9d6f150 into IA-3980-earmarked-stocks-make-obr-name-and-round-selection-not-mandatory Mar 11, 2025
3 checks passed
@mathvdh mathvdh deleted the POLIO-1857_hide_earmarked branch March 11, 2025 13:48
@hakifran hakifran added user tested Has already been tested on staging ok for release Released and removed ok for release labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Should be released in production at next deploy Released user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants