Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download module #413

Merged
merged 8 commits into from
Feb 21, 2025
Merged

Fix download module #413

merged 8 commits into from
Feb 21, 2025

Conversation

svarona
Copy link
Member

@svarona svarona commented Feb 21, 2025 •
edited
Loading

Changes in download module:

  • Added a temporal string to sampleID when sampleID and .fastq files are repeated in order to remove them
  • Fixed renamed of folders not containing any valid sample
  • Added repeated samples to test data

Closes issues #374 and #359

@svarona svarona marked this pull request as ready for review February 21, 2025 09:48
saramonzon
saramonzon previously approved these changes Feb 21, 2025
View reviewed changes
@saramonzon saramonzon dismissed their stale review February 21, 2025 10:06

didn't see Pablo was reviewing xD

@svarona svarona force-pushed the fix_download_module branch from f0ca445 to ff17e24 Compare February 21, 2025 14:03
@svarona svarona force-pushed the fix_download_module branch from ff17e24 to b7186e5 Compare February 21, 2025 14:13
@svarona svarona merged commit 84ceaba into BU-ISCIII:develop Feb 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shettland Shettland Shettland approved these changes

@saramonzon saramonzon saramonzon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svarona @saramonzon @Shettland