Skip to content

refactor: extract OptionRowDescriptiveText leaf #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BartekObudzinski wants to merge 1 commit into from
Closed

refactor: extract OptionRowDescriptiveText leaf #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/components/LHNOptionsList/OptionRowLHN/OptionRowDescriptiveText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import React from 'react';
import {View} from 'react-native';
import Text from '@components/Text';
import useThemeStyles from '@hooks/useThemeStyles';
import FS from '@libs/Fullstory';
import type {Report} from '@src/types/onyx';

type OptionRowDescriptiveTextProps = {
descriptiveText: string | undefined;
report?: Report;
};

function OptionRowDescriptiveText({descriptiveText, report}: OptionRowDescriptiveTextProps) {
const styles = useThemeStyles();

if (!descriptiveText) {
return null;
}

return (
<View
style={[styles.flexWrap]}
fsClass={FS.getChatFSClass(report)}
>
<Text style={[styles.textLabel]}>{descriptiveText}</Text>
</View>
);
}

OptionRowDescriptiveText.displayName = 'OptionRowDescriptiveText';

export default OptionRowDescriptiveText;
15 changes: 5 additions & 10 deletions src/components/LHNOptionsList/OptionRowLHN/OptionRowLHNCore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {StyleSheet, View} from 'react-native';
import Icon from '@components/Icon';
import {useLHNTooltipContext} from '@components/LHNOptionsList/LHNTooltipContext';
import type {OptionRowLHNProps} from '@components/LHNOptionsList/types';
import Text from '@components/Text';
import getContextMenuAccessibilityHint from '@components/utils/getContextMenuAccessibilityHint';
import getContextMenuAccessibilityProps from '@components/utils/getContextMenuAccessibilityProps';
import useEnvironment from '@hooks/useEnvironment';
Expand All @@ -14,14 +13,14 @@ import useOnyx from '@hooks/useOnyx';
import useStyleUtils from '@hooks/useStyleUtils';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import FS from '@libs/Fullstory';
import {shouldUseBoldText} from '@libs/OptionsListUtils';
import {isChatUsedForOnboarding as isChatUsedForOnboardingReportUtils} from '@libs/ReportUtils';
import variables from '@styles/variables';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import OptionRowAlternateText from './OptionRowAlternateText';
import OptionRowAvatar from './OptionRowAvatar';
import OptionRowDescriptiveText from './OptionRowDescriptiveText';
import OptionRowErrorBadge from './OptionRowErrorBadge';
import OptionRowInfoBadge from './OptionRowInfoBadge';
import OptionRowPressable from './OptionRowPressable';
Expand Down Expand Up @@ -143,14 +142,10 @@ function OptionRowLHN({
style={style}
/>
</View>
{optionItem?.descriptiveText ? (
<View
style={[styles.flexWrap]}
fsClass={FS.getChatFSClass(report)}
>
<Text style={[styles.textLabel]}>{optionItem.descriptiveText}</Text>
</View>
) : null}
<OptionRowDescriptiveText
descriptiveText={optionItem?.descriptiveText}
report={report}
/>
<OptionRowErrorBadge
brickRoadIndicator={brickRoadIndicator}
actionBadgeText={actionBadgeText}
Expand Down
Loading