refactor: OptionRowFreeTrialBadge owns onboarding lookup#5
Closed
BartekObudzinski wants to merge 1 commit into
Closed
refactor: OptionRowFreeTrialBadge owns onboarding lookup#5BartekObudzinski wants to merge 1 commit into
BartekObudzinski wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of 5 in the further-decomposition split of OptionRowLHN, layered on top of Expensify#89274 and Expensify#89592.
What
OptionRowFreeTrialBadgeleaf self-subscribes touseOnyx(CONCIERGE_REPORT_ID)+useLHNTooltipContextto derive its ownisChatUsedForOnboardinggate.OptionRowTitleWithStatusno longer takesisChatUsedForOnboardingas a prop, it just renders<OptionRowFreeTrialBadge report={report} />.OptionRowLHNCoredrops theuseOnyx(CONCIERGE_REPORT_ID)subscription, theisChatUsedForOnboardingReportUtilscall, and theonboarding+onboardingPurposereads fromuseLHNTooltipContext(onlyisScreenFocusedremains).Why
isChatUsedForOnboardingwas being computed in two places (Core andOptionRowTooltipLayerfrom Expensify#89274) — same Onyx subscription, same util call, per row. This collapses it to one consumer at the only place it's actually rendered.Risk
This adds one scalar
useOnyx(CONCIERGE_REPORT_ID)per row that mounts the FreeTrialBadge slot — same per-row scalar patternOptionRowTooltipLayeralready uses. Recommend smoke-testingManualNavigateToInboxTabbefore merging.