test: add high-level @iq* quant regression coverage#1
Open
Sanjays2402 wants to merge 2 commits intoBartok9:fix/71474-lmstudio-at-sign-model-namesfrom
Open
test: add high-level @iq* quant regression coverage#1Sanjays2402 wants to merge 2 commits intoBartok9:fix/71474-lmstudio-at-sign-model-namesfrom
Sanjays2402 wants to merge 2 commits intoBartok9:fix/71474-lmstudio-at-sign-model-namesfrom
Conversation
…ution stripModelProfileSuffix() in providers.ts naively truncated model names at the first '@', discarding quant variants like @iq3_xxs, @iq4_xs, @q4_k_xl that LM Studio uses to distinguish quantization levels. This caused two user-facing bugs (fixes openclaw#71474): 1. /model lmstudio/qwen3.6-27b@iq3_xxs → 'model not allowed: lmstudio/qwen3.6-27b' 2. API requests sent truncated model name → LM Studio picked a random quant Changes: - Replace the naive indexOf('@') strip in providers.ts with splitTrailingAuthProfile() which already handles quant suffixes - Extend the quant-suffix regex (q\d+...) to also match importance- quantization tags (iq3_xxs, iq4_xs, ...) via i?q\d+ pattern - Add tests for @iq* quant suffixes and auth-profile-after-iq combos
Locks the two user-visible paths from openclaw#71474: - resolveModelRefFromString preserves `lmstudio/qwen3.6-27b@iq3_xxs` as model id (not truncated to `qwen3.6-27b`). - /model directive: same input keeps the full model, and the trailing `@work` form still splits into model + auth profile. Ported from openclaw#71490 per maintainer review on this PR.
steipete
force-pushed
the
fix/71474-lmstudio-at-sign-model-names
branch
3 times, most recently
from
07ba1cd to
7814343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the high-level test coverage from openclaw#71490 onto your branch, per steipete's review.
Adds 4 tests at the symptom sites — so any future regression in either layer fails at the user-visible path, not just the splitter.
src/agents/model-selection.test.ts(+2)resolveModelRefFromStringpreserveslmstudio/qwen3.6-27b@iq3_xxsas the model id@workcorrectly splits the auth profilesrc/auto-reply/model.test.ts(+2)/model lmstudio/qwen3.6-27b@iq3_xxskeeps the full model id, no profile/model lmstudio/qwen3.6-27b@iq3_xxs@workkeeps the full model id withworkprofileVerification
model-ref-profile,model-selection,auto-reply/modeloxlintcleanTests-only, no code changes — all behavior comes from your existing parser + provider patch.