-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vim-alias): add full screen help #1734
Conversation
hey @georgettica PS: Would you like to clean this alias file as part of #1696? |
I can do that, but not sure how to run the pre-commit check |
You need to add your file to We will add docs about it asap so it will be clearer |
I was actually looking at the pt you referenced me in. |
|
@georgettica seems like you need to install Also make sure to install |
Okidok. |
@NoahGorny added what you requested now :) hope it's good enough |
@georgettica amazing work! Thanks for your contribution ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment, otherwise looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @georgettica !
Yay! |
I don't use it very often and am fine with not putting it in, but worth pushing it out there