Skip to content

Anova#31

Merged
MaartenMarsman merged 45 commits intomainfrom
anova
Feb 3, 2025
Merged

Anova#31
MaartenMarsman merged 45 commits intomainfrom
anova

Conversation

@MaartenMarsman
Copy link
Collaborator

This is a major update to bgmCompare, which now allows for the comparison for two or more groups.

List of to do's (from .._anova.cpp):
1. Fix "main_model = "Free"".
2. Use "index" to vary updates to pairwise effects.
3. Add between model moves.
4. Add g prior.
5. Output for ``save''.
List of to do's (from _anova.cpp)
1. Use "index" to vary updates to pairwise effects.
2. Add between model moves.
3. Add g prior.
4. Output on ``save''
* bgmCompare; function documentation, output handling
* utility_functions; helper functions for data checks and output handling
* gibbs_..._anova.cpp; save options, dynamic declaration of output
Implemented RcppArmadillo for more efficient memory management in bgmCompare().
* Added full-conditional for the selection of category threshold differences for regular ordinal variables.
* Small performance improvement

print.bgms:
* Update to variable name changes.
…g code can be used to compare new to old code.

a = Wenchuan[1:50,1:5] - 1
b = Wenchuan[151:200,1:5] - 1

a = na.omit(a)
b = na.omit(b)

a[a[,1]==3,1] = 2
xx = rbind(a,b)
group = as.vector(c(rep(1, nrow(a)), rep(2, nrow(b))))

t = bgmCompare_dev(x = a, y = b,
               t.test = TRUE,
               main_difference_model = "Collapse",
               difference_selection = FALSE,
               save = FALSE)

an = bgmCompare(x = xx,
                g = group,
                main_difference_model = "Collapse",
                difference_selection = FALSE,
                save = FALSE)

par(mfrow = c(2,2))
plot(t$posterior_mean_pairwise[,1], an$posterior_mean_pairwise[,1]); abline(0,1)
plot(t$posterior_mean_pairwise[,2], an$posterior_mean_pairwise[,2]); abline(0,1)
if("posterior_mean_indicator" %in% names(t)) {
  plot(t$posterior_mean_main, an$posterior_mean_main); abline(0,1)
  plot(t$posterior_mean_indicator, an$posterior_mean_indicator,
       xlim = c(0,1), ylim = c(0,1)); abline(0,1)
} else {
  plot(t$posterior_mean_main[,1], an$posterior_mean_main[,1]); abline(0,1)
  plot(t$posterior_mean_main[,2], an$posterior_mean_main[,2]); abline(0,1)
}
@MaartenMarsman
Copy link
Collaborator Author

@vandenman Heb jij een idee waarom de Windows check faalt?

@vandenman
Copy link
Collaborator

Heb je geprobeerd een Makevars.win te maken zoals hier? Die skeleton functie van rcpparmadillo zou dat ook maken, maar wel vreemd dat je er op de andere platforms geen nodig hebt.

@MaartenMarsman
Copy link
Collaborator Author

MaartenMarsman commented Feb 3, 2025 via email

@MaartenMarsman MaartenMarsman merged commit 9615e95 into main Feb 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants