Skip to content

Implement the ability to change the backlight mode #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fede2782 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement the ability to change the backlight mode #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,19 @@ Led subsystem allows us to control the leds on the laptop including the keyboard
- 2: Half
- 3: Full

- `/sys/class/leds/msiacpi::kbd_backlight/available_kbd_bl_modes`
- Description: This entry reports all supported keyboard backlight modes.
- Access: Read
- Valid values: Newline separated list of strings.

- `/sys/class/leds/msiacpi::kbd_backlight/kbd_bl_mode`
- Description: This entry allows switching the keyboard backlight mode. It allows control on when to use the keyboard backlight.
- Access: Read, Write
- Valid values:
- Values reported by `/sys/class/leds/msiacpi::kbd_backlight/available_kbd_bl_modes`. Some of the possible values:
- always: always keep the keyboard backlight enabled.
- timeout: automatically disable the keyboard backlight after 10s from last interaction with they keyboard or touchpad.

### Debug mode

You can use module *parameters* to get direct read-write access to the EC or force-load a configuration
Expand Down
2 changes: 1 addition & 1 deletion ec_memory_configuration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ struct msi_ec_led_conf {
#define MSI_EC_KBD_BL_STATE_MASK 0x3
struct msi_ec_kbd_bl_conf {
int bl_mode_address;
int bl_modes[2];
struct msi_ec_mode bl_modes[5];
Copy link
Copy Markdown
Collaborator

@glpnk glpnk Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 5 not 3?

Because states are "always", "timeout" and NULL

Copy link
Copy Markdown
Contributor Author

@Fede2782 Fede2782 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 5 not 3?

Because states are "always", "timeout" and NULL

I have aligned with other modes definition. Also this allows better handling in case new modes are added in the future. This can be reduced to 3 if you think is necessary.

int max_mode;

int bl_state_address;
Expand Down
Loading