Fix calls being declined automatically on reception when defining a call timeout#262
Open
fhilleriteau-fdi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit fe504f0e40875e4cc4e729b13422ec277760008d introduced a bug which causes liblinphone to decline every call on reception when a call timeout is configured.
The commit
fe504f0echanged the default value ofmConnectedTime(Connecting date of the call in seconds as expressed in a time_t) from 0 to -1, but did not apply this change to the condition checking if the call duration should be compared with the call timeout parameter, to stop the call. The condition checks ifmConnectedTimehas been set by comparing it to its old default value (0) instead of the new one (-1).