fix bug, linphone_core_accept_call will be crash when call is NULL, use by linphonec#30
Open
smallmuou wants to merge 1 commit into
Open
fix bug, linphone_core_accept_call will be crash when call is NULL, use by linphonec#30smallmuou wants to merge 1 commit into
smallmuou wants to merge 1 commit into
Conversation
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Nearly i meet a issue, that when i use linphonec command to answer a call, it will crash. And I found it cause by linphone_core_accept_call(lc, NULL), see code bellow.
++++++++++console/commands.c++++++++
static int
lpc_cmd_answer(LinphoneCore *lc, char *args){
...
if ( -1 == linphone_core_accept_call(lc, NULL) )
{
linphonec_out("Fail to accept incoming call\n");
}
...
++++++++++++++++++++++++++++++++++
so I fix linphone_core_accept_call like this:
++++++++++coreapi/linphonecore.c++++++++
LinphoneStatus linphone_core_accept_call(LinphoneCore *lc, LinphoneCall *call) {
return linphone_core_accept_call_with_params(lc, call, NULL);
}
++++++++++++++++++++++++++++++++++