Conversation
…and details of the selected universe from universes.html
BenDavidAaron
left a comment
BenDavidAaron
left a comment
There was a problem hiding this comment.
Left a few nits and some cleanup comments. Can be ready to merge in 15 mins of work or so IMO.
| .await | ||
| } | ||
|
|
||
| pub async fn select_universes_by_user_id( |
There was a problem hiding this comment.
Nit: This function's name is a little choppy. It fetches all the universes that a user is associated with, but we should consider breaking this up by permissions level in future work.
Can you think of a more descriptive name?
Not a blocker
There was a problem hiding this comment.
I'm not so certain on this one so I left it as is. Would 'select_user_universes_by_user_id' be more appropriate?
| } | ||
| } | ||
|
|
||
| async fn get_universes( |
There was a problem hiding this comment.
Nit: Move this function up a few lines so it's below get_universe, just for ease of browsing later.
There was a problem hiding this comment.
Moved the function
| throw error; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
What if a user want's to delete a universe or change the name of a universe?
There was a problem hiding this comment.
Consider this function:
groknag/static/js/playerCharacter.js
Line 59 in e84ddf5
and this function
groknag/static/js/playerCharacter.js
Line 84 in e84ddf5
We want to have JS in the client that allows the browser to request updates or deletion of a universe. I think we should leave universe deletion out of the UI for now, since that's a mega destructive action.
There was a problem hiding this comment.
Users can now update the name and description of their universes
| <a href="/index.html">Home</a> | ||
| <a href="/campaigns.html">Campaigns</a> | ||
| <a href="characters.html">Characters</a> | ||
| <a href="/universes.html">Universes</a> |
There was a problem hiding this comment.
Nit: Move this link ahead of Campaigns so it's first in the eye flow.
There was a problem hiding this comment.
Moved the link
| }; | ||
|
|
||
| /* | ||
| const renderCampaignList = async () => { |
There was a problem hiding this comment.
Can you delete these commented out functions, it's sloppy to leave them in, especially in client side code that users can see 😉
|
|
||
|
|
||
| /* | ||
| const handleCampaignCreate = async (event) => { |
BenDavidAaron
changed the title
| throw error; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Consider this function:
groknag/static/js/playerCharacter.js
Line 59 in e84ddf5
and this function
groknag/static/js/playerCharacter.js
Line 84 in e84ddf5
We want to have JS in the client that allows the browser to request updates or deletion of a universe. I think we should leave universe deletion out of the UI for now, since that's a mega destructive action.
2 participants
No description provided.