Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bertozzi consistent #218

Closed

Conversation

stephanmg
Copy link
Collaborator

Make Bertozzi's Susceptible_to_Infected consistent.

@stephanmg stephanmg changed the title Fix bertozzi Make Bertozzi consistent Jun 27, 2024
@dilpath
Copy link
Collaborator

dilpath commented Jun 28, 2024

What is inconsistent? The Susceptible -> Infected reaction is not reversible, right?

@stephanmg
Copy link
Collaborator Author

Susceptible_to_Infected
Rate Law for Susceptible_to_Infected_1
The kinetic function is marked as irreversible but at least one of its variables is labeled as product. 

@dilpath
Copy link
Collaborator

dilpath commented Jun 28, 2024

Is this forbidden in SBML? The interaction between susceptible + infected causes susceptible -> infected, not infected -> susceptible, right?

@stephanmg
Copy link
Collaborator Author

stephanmg commented Jun 28, 2024

Is this forbidden in SBML? The interaction between susceptible + infected causes susceptible -> infected, not infected -> susceptible, right?

Ah, the interaction should be non-reversible true. So what about this message from COPASI/SBML validator? False-positive warning?

@dilpath
Copy link
Collaborator

dilpath commented Jun 28, 2024

False-positive warning?

I'm not sure, but this is my guess -- maybe it's unusual to see direct positive-feedback with the product in the kinetic law.

@FFroehlich
Copy link
Collaborator

FFroehlich commented Jun 29, 2024

I think the rate law should be susceptible + infected -> infected + infected rather than susceptible -> infected

@dilpath
Copy link
Collaborator

dilpath commented Jun 29, 2024

I think the rate law should be susceptible + infected -> infected + infected rather than susceptible -> infected

Ah thanks, makes sense, done in #222 , where the problem is further modified to be a more reasonable parameter estimation problem.

@stephanmg
Copy link
Collaborator Author

Can this issue then be closed in light of additional fixes in #222?

@dilpath dilpath closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants