Glycin fixes #1928
Open
Glycin fixes #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent GDK-PixBuf with Glycin will attempt to spawn sandboxed loaders, which needs `bwrap` from the PATH.
qarkai
reviewed
Sep 28, 2025
As mentioned in the bugs referenced, clearing the pixbuf in the prepared signal is not a valid thing to do. See: https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/75ac8deaf04f362efa5fc0ace51031350e70e8be Closes: BestImageViewer#1921
heftig
force-pushed
the
glycin-fixes
branch
from
4e29293 to
7b90425
Compare
xsdg
reviewed
Sep 29, 2025
|
|
||
| echo "Variables in isolated environment:" >&2 | ||
| env -i G_DEBUG="$G_DEBUG" HOME="$HOME" XDG_CONFIG_HOME="$XDG_CONFIG_HOME" XDG_RUNTIME_DIR="$XDG_RUNTIME_DIR" dbus-run-session -- env >&2 | ||
| env -i G_DEBUG="$G_DEBUG" HOME="$HOME" PATH="$PATH" XDG_CONFIG_HOME="$XDG_CONFIG_HOME" XDG_RUNTIME_DIR="$XDG_RUNTIME_DIR" dbus-run-session -- env >&2 |
Contributor
There was a problem hiding this comment.
I'm not a fan of this solution. The intent of this script is to create a sandbox where (especially) the geeqie being tested cannot interact with other versions of geeqie that might be installed on the system (including in the default PATH). Passing PATH through unmodified creates a hole in that sandbox.
Would it be possible to symlink bwrap into the sandbox and add that to the sandbox PATH? Something like
SANDBOX_PATH="${HOME}/bin"
mkdir -p "$SANDBOX_PATH"
# If `bwrap` is installed, symlink it into the sandbox PATH. Used by glycin GdkPixuf.
if which bwrap > /dev/null; then
ln -s "$(which bwrap)" "${SANDBOX_PATH}/"
fi
[...]
env [...] PATH="$SANDBOX_PATH"
Contributor
There was a problem hiding this comment.
Would be great to fix GdkPixbuf bug already.
Is it possible to merge this partially, i.e. just commit Stop overwriting prepared image data?
Another option is merge whole PR and apply @xsdg suggestion later in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't remove PATH from tests
A recent GDK-PixBuf with Glycin will attempt to spawn sandboxed loaders,
which needs
bwrapfrom the PATH.Stop overwriting prepared image data
As mentioned in the bugs referenced, clearing the pixbuf in the prepared
signal is not a valid thing to do.
See: https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/75ac8deaf04f362efa5fc0ace51031350e70e8be
For: PNGs not rendering on new arch install #1921