Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create registration page #11

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Create registration page #11

merged 2 commits into from
Jul 31, 2024

Conversation

plzfday
Copy link
Member

@plzfday plzfday commented Jul 29, 2024

Resolves #5

The changes are:

  • New register page
  • Terms and Conditions modal
  • Also considered mobile view

image
image

@plzfday plzfday requested review from utilForever and kidw0124 July 29, 2024 07:09
@plzfday plzfday self-assigned this Jul 29, 2024
@plzfday plzfday changed the title 5 create registration page Create registration page Jul 29, 2024
@plzfday plzfday force-pushed the 5-create-registration-page branch from b15c730 to 1a53986 Compare July 30, 2024 15:18
Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write some unit tests for email validation, password check and so on?

@plzfday
Copy link
Member Author

plzfday commented Jul 31, 2024

There's no validation process at the moment. Do you think this PR includes it? I suggest adding that later when we connect with the backend.

@utilForever
Copy link
Member

There's no validation process at the moment. Do you think this PR includes it? I suggest adding that later when we connect with the backend.

I think that some tests such as email validation and password check can be tested with client-side. I'm not sure why you need the backend to do these tests.

Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Through the discussion, we decided to work on the test code in another PR.

@plzfday plzfday merged commit a1431bb into main Jul 31, 2024
1 check passed
@plzfday plzfday deleted the 5-create-registration-page branch July 31, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Registration page
2 participants