Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create landing page #8

Merged
merged 9 commits into from
Jul 27, 2024
Merged

Create landing page #8

merged 9 commits into from
Jul 27, 2024

Conversation

plzfday
Copy link
Member

@plzfday plzfday commented Jul 26, 2024 •
edited
Loading

Resolves #1

This revision includes:

  • Implement a Navigation bar.
  • Landing page content with the MUI Card component. This should be updated to fetch data dynamically from the server.

image

@plzfday plzfday requested review from utilForever and kidw0124 July 26, 2024 08:38
@plzfday plzfday self-assigned this Jul 26, 2024
@plzfday plzfday linked an issue Jul 26, 2024 that may be closed by this pull request
Create Landing page #1
Closed
4 tasks
utilForever
utilForever approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your work! 🎉
BTW, why the filename Navigation.tsx starts with uppercase only? 🤔

@plzfday
Copy link
Member Author

plzfday commented Jul 27, 2024 •
edited
Loading

AFAIK, it's standard in NextJS. page.tsx and layout.tsx must be lower cases but the component files should be capitalised.

@plzfday plzfday merged commit 75b1bb2 into main Jul 27, 2024
1 check passed
@plzfday plzfday deleted the 1-create-landing-page branch July 27, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utilForever utilForever utilForever approved these changes

@kidw0124 kidw0124 Awaiting requested review from kidw0124

Assignees

@plzfday plzfday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Landing page
2 participants
@plzfday @utilForever