-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsible Side Panel #105
Collapsible Side Panel #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start! The moon icon is a nice touch.
I believe the takeaways from the meeting on 2/22/24 were:
- The sidebar content being invisible when the sidebar is collapsed
- The icon to slide the sidebar in and out should be larger and visually in its own container like a tab on a file
- The logo should always be visible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not using the react-pro-sidebar
, right? I bet you just need to delete your package-lock
file so that one can be regenerated that will have no conflicts with staging. If you're having trouble, you may want to totally delete node_modules
and regenerate everything from staging's package
file.
It looks great though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a note on how to use Jotai consistent with the rest of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think workflows need to be updated to run GitHub checks on pull request. Currently, it's only on push. See BAR API example: |
I think there's a setting change that needs to be done, having a PR trigger just runs the action when you first open a PR which is not what we want. See this StackOverflow post @asherpasha |
This is done. Please try again. |
I'm still having the pending problem with the build and lint-and-format checks. It looks like there are other PRs from Jamie and Mike that want to merge their forked branches to staging too |
Closes Issue #86