Some optimizations to tree intersection#46
Open
dcjones wants to merge 3 commits into
Open
Conversation
|
Please do report any cases that you encounter like this where |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 97.65% 97.18% -0.48%
==========================================
Files 3 3
Lines 596 603 +7
==========================================
+ Hits 582 586 +4
- Misses 14 17 +3
Continue to review full report at Codecov.
|
3b9146d to
54172c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some progress on reducing overhead in the tree intersection iterator. My test case is finding all intersections between RNA-Seq reads and annotated transcripts in a dataset with ~18 million such intersections. With this I was able to improve run time from 46 seconds to 6.7 seconds.
Don't ask me to explain why storing the state in nullables works better than
Union{Nothing, ...}. The compiler works in mysterious ways. 🤷♂️