Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChEMBL Data Catalog to live deploys #458

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Add ChEMBL Data Catalog to live deploys #458

merged 1 commit into from
Oct 22, 2021

Conversation

AlasdairGray
Copy link
Member

No description provided.

ljgarcia
ljgarcia reviewed Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@ljgarcia ljgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but version used is missing. Any chance they can easily/quickly add it?
If not, should I go for an issue and accept this PR?

@AlasdairGray
Copy link
Member Author

I'd deliberately left the version out since the markup does not conform with any version. Probably best to make it an issue.

@ljgarcia
Copy link
Collaborator

Issue created BioSchemas/specifications#544

@ljgarcia ljgarcia merged commit b0378dc into master Oct 22, 2021
@ljgarcia ljgarcia deleted the chembl-data-catalog branch October 22, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljgarcia ljgarcia ljgarcia approved these changes

Assignees
No one assigned
Labels
Live Deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlasdairGray @ljgarcia