-
Notifications
You must be signed in to change notification settings - Fork 4
Fix extractManuals #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
@hpages Could you review when you have time It isn't great because I realized |
This should be merged before Bioconductor/BBS#438, which removes functionality to extract manuals created during the build process that contain internal functions. |
Hi @vjcitn @lshep Could I ask one of you to review the changes here? I'm also open to suggestions to improve it. This PR expands
For testing, I made CRAN-style repo and curled the sources from the Bioconductor website to
The result of running
|
Allow
extractManuals
to work on software and experiment tarballs while fixing problems related to the two types of data annotation tarballs. Some data annotation packages are built by the BBS while others are produced outside of it. Currently, reference manuals may be produced twice for the manuals built by the BBS because it is first produced bymake-OUTGOING.py
in the BBS then later during the propagation step,extractManuals
is called. SometimesextractManuals
can fail to create the reference manual resulting in no manual being available.More background: Bioconductor/BBS#444
Close #18