Methods needed for Covenants in Script#3
Open
jcramer wants to merge 2 commits into
Open
Conversation
|
These look like they are only additive changes, which removes the risk of regression bugs. This should be safe to merge. |
Author
|
@christroutner I will likely be adding some bits to this over the next few weeks. We want to have an option in the method to return the whole preimage, rather than the chunks. |
|
I like the idea of also being able to return the full preimage, but I think returning chunks is valuable too. Perhaps hPhSoBuf could be further broken up as well, in case someone might need it later on. |
Author
|
Good idea, I can have it broken up to leave it up to the consumer to combine the chunks as they wish. I'll add a method parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to share two methods I used for the purpose of creating a Covenant type script contract. The LastWill contract is an example that uses this preimage data within the "refresh" scriptSig.
sigHashPreimageBufChunks(inIndex, prevOutScript, value, hashType)-->sigHashPreimageBuf(inIndex, prevOutScript, value, hashType)--> sigHash preimage buf