Skip to content

Gemfile update #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gemfile update #1187

wants to merge 2 commits into from

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented Jul 21, 2025

A few peeps have/had problems running the site locally. Mr. AI is telling me that this may be an issue with webrick and later versions of Ruby.

This update is based on recommendations by said Mr. AI. Let's test and see if these fixes help resolve the problems, and we can iterate as needed.

Check the preview <-- should look exactly the same as the live site

A few peeps have/had problems running the site locally. Mr. AI is telling me that this may be an issue with webrick and later versions of Ruby.

This update is based on recommendations by said Mr. AI. Let's test and see if these fixes help resolve the problems, and we can iterate as needed.
Copy link

netlify bot commented Jul 21, 2025

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit f0fb979
🔍 Latest deploy log https://app.netlify.com/projects/bitcoin-design-site/deploys/687df1694227ac0008ea5c90
😎 Deploy Preview https://deploy-preview-1187--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GBKS GBKS requested a review from Copilot July 21, 2025 07:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Gemfile to address local development issues that users have experienced with Ruby compatibility, particularly related to webrick and newer Ruby versions. The changes modernize dependency versions and improve code organization.

  • Updates Jekyll from version 4.1.1 to 4.4 for better Ruby compatibility
  • Updates jekyll-feed plugin from 0.12 to 0.17
  • Changes webrick version constraint from exact to minimum version requirement
  • Reorganizes and improves comments for better clarity and structure

Co-authored-by: Copilot <[email protected]>
Copy link
Collaborator

@swedishfrenchpress swedishfrenchpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Preview works fine so I think this is a safe update.

@GBKS
Copy link
Contributor Author

GBKS commented Jul 21, 2025

Great. Let's make sure we get some people to test this locally before we merge.

@vivekgh0sh
Copy link

I tested this build on a windows system and it had two major errors:

  • io-event - fatal error: sys/wait.h: No such file or directory
  • wdm - error: implicit declaration of function 'rb_thread_call_without_gvl'

Mr. AI told me to delete these two lines with the trade off not being able to run the link-checker locally (html-proofer) and not being able to detect file changes automatically (wdm).
gem "html-proofer"
gem "wdm", "~> 0.1.1"

After deleting these two lines the build ran as expected but with the trade offs mentioned above.

I asked Mr. AI for a better solution and it recommend to use wsl. wsl worked but I had to configure wsl.conf file for it to work.

@swedishfrenchpress
Copy link
Collaborator

I tested this build on a windows system and it had two major errors:

  • io-event - fatal error: sys/wait.h: No such file or directory
  • wdm - error: implicit declaration of function 'rb_thread_call_without_gvl'

Mr. AI told me to delete these two lines with the trade off not being able to run the link-checker locally (html-proofer) and not being able to detect file changes automatically (wdm). gem "html-proofer" gem "wdm", "~> 0.1.1"

After deleting these two lines the build ran as expected but with the trade offs mentioned above.

I asked Mr. AI for a better solution and it recommend to use wsl. wsl worked but I had to configure wsl.conf file for it to work.

If modifying .wsl.conf is a better solution than losing the link checker and file change detection, should we recommend this as the default way for Windows users to run the design guide locally? Are there any known trade-offs with this .wsl.conf configuration approach?

@vivekgh0sh
Copy link

I would say yes WSL is a better approach for local build in a windows machine. And the changes required in wsl.conf are to prevent WSL from automatically appending the windows PATH. This is a preventive measure as to when we run bundle install(or any other command) it doesn't try to access the windows PATH and throw a error.

We just need to add these two lines in the wsl.conf file:
[interop]
appendWindowsPath = false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants