-
Notifications
You must be signed in to change notification settings - Fork 112
Gemfile update #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Gemfile update #1187
Conversation
A few peeps have/had problems running the site locally. Mr. AI is telling me that this may be an issue with webrick and later versions of Ruby. This update is based on recommendations by said Mr. AI. Let's test and see if these fixes help resolve the problems, and we can iterate as needed.
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Gemfile to address local development issues that users have experienced with Ruby compatibility, particularly related to webrick and newer Ruby versions. The changes modernize dependency versions and improve code organization.
- Updates Jekyll from version 4.1.1 to 4.4 for better Ruby compatibility
- Updates jekyll-feed plugin from 0.12 to 0.17
- Changes webrick version constraint from exact to minimum version requirement
- Reorganizes and improves comments for better clarity and structure
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Preview works fine so I think this is a safe update.
Great. Let's make sure we get some people to test this locally before we merge. |
I tested this build on a windows system and it had two major errors:
Mr. AI told me to delete these two lines with the trade off not being able to run the link-checker locally (html-proofer) and not being able to detect file changes automatically (wdm). After deleting these two lines the build ran as expected but with the trade offs mentioned above. I asked Mr. AI for a better solution and it recommend to use wsl. wsl worked but I had to configure |
If modifying .wsl.conf is a better solution than losing the link checker and file change detection, should we recommend this as the default way for Windows users to run the design guide locally? Are there any known trade-offs with this .wsl.conf configuration approach? |
I would say yes WSL is a better approach for local build in a windows machine. And the changes required in We just need to add these two lines in the |
A few peeps have/had problems running the site locally. Mr. AI is telling me that this may be an issue with webrick and later versions of Ruby.
This update is based on recommendations by said Mr. AI. Let's test and see if these fixes help resolve the problems, and we can iterate as needed.
Check the preview <-- should look exactly the same as the live site