fix: restore Go module build and normalize segwit HRP checks - #2
Open
tolga-tom-nook wants to merge 2 commits into
Open
fix: restore Go module build and normalize segwit HRP checks#2tolga-tom-nook wants to merge 2 commits into
tolga-tom-nook wants to merge 2 commits into
Conversation
This was referenced May 25, 2026
Closed
|
Review-assist note for the Bitgesell #81 improvement lane. I checked the public PR body and diff. This is a focused Go module/build restoration fix:
Suggested maintainer checks before merge:
From the public patch shape, this looks like a useful low-risk build/testability candidate for the #81 improvement queue. I did not run Go, parse chainstate, access wallets, payment, or live-chain actions for this review-assist note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This restores a clean Go module build for
bitgesell-utxo-dumpafter the repository was moved underBitgesellOfficial:go.mod/go.sumfor the current package tree;naftalimurgor/in3rshapaths to the canonicalgithub.com/BitgesellOfficial/bitgesell-utxo-dumpmodule path;fmt.Printlnformatting misuse so the package passesgo test ./...cleanly.RED / GREEN proof
RED on upstream
origin/main(02ec2c1):GREEN on this branch:
git diff --check origin/main...HEADis clean.Bounty context
Submitted for the Bitgesell improvement / PR bounty program:
Payout address, if accepted:
0x4a76c7E64C08cF29B59eFC640b4ada97A270d428(EVM/USDT-compatible).Additional validation/update (2026-06-05):
SegwitAddrDecodeto normalize the expected HRP before comparing it withDecode's lowercased HRP result. This keeps the decoder consistent with the package's ownEncode("BGL", ...)behavior and avoids rejecting valid all-uppercase Bech32 strings.go test ./src/bitgesell/bech32 -run TestSegwitAddrDecodeAcceptsUppercaseHRP -count=1go test ./...git diff --check