add Bitgesell coin parameters - #1
Open
newmattock wants to merge 2 commits into
Open
Conversation
|
Review-assist note for the Bitgesell spesmilo#81 improvement lane. I checked the public PR metadata and diff. This is a focused ElectrumX integration patch:
Suggested maintainer checks before merge:
From the public patch shape, this looks like a useful low-risk ElectrumX enablement candidate for the spesmilo#81 improvement queue. I did not run tests, start ElectrumX, connect to a node, use wallet keys, submit payment details, or perform any live-chain action for this review-assist note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds Bitgesell mainnet and testnet coin definitions to ElectrumX.
Related bounty or issue:
BitgesellOfficial/bitgesell#81
What changed:
BitgesellandBitgesellTestnetcoin classes with mainnet/testnet genesis hashes, address prefixes, WIF bytes, xpub/xprv bytes, RPC ports, and SegWit deserialization.BitgesellOfficial/bitgesellCore chainparams.Validation:
PYTHONPYCACHEPREFIX=/private/tmp/bitgesell-pycache python3 -m py_compile electrumx/lib/coins.py tests/lib/test_bitgesell_coin.pyPYTHONDONTWRITEBYTECODE=1 /private/tmp/electrumx-bitgesell-venv/bin/python -m pytest tests/lib/test_bitgesell_coin.py -q(2 passed)PYTHONDONTWRITEBYTECODE=1 /private/tmp/electrumx-bitgesell-venv/bin/python -m pytest tests/lib/test_coins.py -q(16 passed)git diff --checkNotes:
I did not run the full suite because this local environment was only provisioned with the dependencies needed for the coin tests.