-
Notifications
You must be signed in to change notification settings - Fork 22
transactions - new page #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transactions - new page #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks like a copy of the old PHP code—we don't need that.
PHP has great functionality, and we need to have the same functionality. but the code is very messy; we shouldn't copy it.
We have the nice and clean code for /transaction/ - most of the utils we need are already in use there, and the structure is nice there; we need the same just for /transactions/
we don't need to copy php, we need to write a new code from scratch.
you should relay or xrpl documentation, rather than old php code.
Php code is needed, not miss all the functionaly we had there..
we need all the functionality we had in php plus all the new one according the documentaton, whcih is missed in php.
the structure should be similiar to /transaction/ - means
we have a component for common firlds between different transactions.
like transaction hash, time and date etc
then we need to have separate components for different transactions types.
Right now, it is the same mess as we had in PHP - we won't merge it unless it is structured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please return the comments and answer some questions.
…/bithomp-frontend-react into feat/445/transactions-page
This code is repeated in many transaction types, as many of them need the historical price. (we shouldn't not copy-paste the code to different places) |
If we reuse some functions from the /transaction/ for /transactions/, they would need to be subtracted as well, not copy-pasted, but that can be done later in a separate PR, For now we just focus on the structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subtract the same code from each component to one level up and reuse it.
@ihomp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many things to fix, but we will address them in separate tickets
Issue
We need to create a new page to show all transactions of the wallet.