Skip to content

bug in the token select on /send page #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@pandablue0809 pandablue0809 requested a review from ihomp July 29, 2025 09:52
Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets address my commnets in the ticket.
1 - it still loads uncreated trustlines
2 - updates the list on opening, when no params changed.

@pandablue0809 pandablue0809 requested a review from ihomp August 1, 2025 14:35
@pandablue0809
Copy link
Member Author

@ihomp
I fixed reload issue

@ihomp
Copy link
Member

ihomp commented Aug 4, 2025

on the send page

http://localhost:3000/en/services/send

if I chose a currency for example RLUSD

  • close the token selector
  • re-open token selector -> it will show the loading state - even though nothing is changed ... we shouldn't have data reloads when search is not changed.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still reloads the token list when opening token selector for the second time.

@pandablue0809 pandablue0809 requested a review from ihomp August 5, 2025 12:26
@pandablue0809
Copy link
Member Author

@ihomp
fixed

@ihomp
Copy link
Member

ihomp commented Aug 6, 2025

The PR looks good...
However, if I choose "XRP" and close the token selector, when I reopen it, it still "reloads" the list and shows "XRP".

Now, the token selector doesn't show the issued tokens by the destination address; we need to use a different one, or the one we use should be updated @ildaruz

@ihomp
Copy link
Member

ihomp commented Aug 14, 2025

@pandablue0809 please update the endpoint to use

/v2/address/:address/acceptedTokens

@ihomp
Copy link
Member

ihomp commented Aug 14, 2025

priority 0 @Anna15170221

@pandablue0809
Copy link
Member Author

@ihomp
I fixed

@ihomp
Copy link
Member

ihomp commented Aug 20, 2025

@ildaruz the data seems invalid, we only need the list of tokens, not all the trustlines

https://bithomp.com/api/v2/address/rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B/acceptedTokens?limit=20

priority 0.

plus add the nativeToken: XRP/XAHAU

@ihomp ihomp merged commit 23bb767 into Bithomp:main Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants