-
Notifications
You must be signed in to change notification settings - Fork 22
bug in the token select on /send page #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug in the token select on /send page #499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets address my commnets in the ticket.
1 - it still loads uncreated trustlines
2 - updates the list on opening, when no params changed.
…point-token-selector
@ihomp |
on the send page http://localhost:3000/en/services/send if I chose a currency for example RLUSD
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still reloads the token list when opening token selector for the second time.
@ihomp |
The PR looks good... Now, the token selector doesn't show the issued tokens by the destination address; we need to use a different one, or the one we use should be updated @ildaruz |
@pandablue0809 please update the endpoint to use
|
priority 0 @Anna15170221 |
@ihomp |
@ildaruz the data seems invalid, we only need the list of tokens, not all the trustlines https://bithomp.com/api/v2/address/rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B/acceptedTokens?limit=20 priority 0. plus add the nativeToken: XRP/XAHAU |
Issue
when destination is entered: instead of showing ONLY the tokens that account can hold we show rubbish trustlines that were set by third parties to the destination address.