ci: fase 1 guardrails para Aegis#2
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc1c870e81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| await expect(page).toHaveTitle(/AEGIS/i); | ||
| await expect(page.getByRole('heading', { name: 'AEGIS' }).first()).toBeVisible(); | ||
| await expect(page.getByLabel('Open AEGIS VECTOR GPS navigation')).toBeVisible(); |
There was a problem hiding this comment.
Because .github/workflows/ci.yml now runs npm run test:e2e on every PR, this assertion makes the new smoke job fail even when the homepage loads: Open AEGIS VECTOR GPS navigation does not appear in the app source as label text or an aria-label (checked src/app and src/components; the only match is this test), so Playwright will wait until timeout. Please assert an existing accessible control or add this label to the UI.
Useful? React with 👍 / 👎.
|
|
||
| await expect(page).toHaveTitle(/AEGIS/i); | ||
| await expect(page.getByRole('heading', { name: 'AEGIS' }).first()).toBeVisible(); | ||
| await expect(page.getByText('CORTEX').first()).toBeVisible(); |
There was a problem hiding this comment.
Because the new CI workflow invokes the e2e suite, this mobile smoke test times out on a healthy page: CORTEX is not rendered anywhere in the app source (checked src/app and src/components; the only match is this test). Please update the assertion to text that actually exists on the mobile command surface, or add the intended copy to the UI.
Useful? React with 👍 / 👎.
2 participants
Resumen
Verificación local
Nota
Este PR aísla solo la Fase 1 de guardrails/CI y no mezcla otros cambios locales aún no preparados.