test: validate ETHBankContract logic#41
Open
zintarh wants to merge 4 commits intoBlockheaderWeb3-Community:mainfrom
Open
test: validate ETHBankContract logic#41zintarh wants to merge 4 commits intoBlockheaderWeb3-Community:mainfrom
zintarh wants to merge 4 commits intoBlockheaderWeb3-Community:mainfrom
Conversation
sprtd
reviewed
Apr 22, 2024
Contributor
sprtd
left a comment
sprtd
left a comment
There was a problem hiding this comment.
@kateberryd please take a look at the reviews
| @@ -12,15 +14,121 @@ describe("ETHBank Test Suite", function () { | |||
|
|
|||
| describe("Post Deployment State Variables", async () => { | |||
Contributor
There was a problem hiding this comment.
This describe block should be Deployment
| }); | ||
|
|
||
| describe("Transactions", async () => { | ||
| describe("Deposit Validations", async () => { |
Contributor
There was a problem hiding this comment.
Under Transactions, you should have sub-wrappers - Deposit and Withdrawal
To appropriately categorize your test cases, under each of these, ensure you have corresponding Validation, Transactions and Events describe wrappers and each with its it test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.