Open
Conversation
ibsule
requested changes
Feb 24, 2025
Collaborator
ibsule
left a comment
ibsule
left a comment
There was a problem hiding this comment.
Update PR title to contain a one-line summary of your PR
ibsule
requested changes
Feb 24, 2025
Collaborator
ibsule
left a comment
ibsule
left a comment
There was a problem hiding this comment.
Please deploy contracts and providing sample transaction as stated in 4.
| pragma solidity ^0.8.24; | ||
|
|
||
| interface IERC721{ | ||
| function _mint(address to, uint256 tokenId) external; |
Collaborator
There was a problem hiding this comment.
By convention, external functions are not named with an underscore.
Update _mint() to mint()
Author
There was a problem hiding this comment.
yes sir...
God bless the instructor sir
Author
pls, should i send it as a screenshot? |
Collaborator
|
Send the transaction hash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my implementation of a crowdfunding contract written in solidity: Link here [https://github.com/BlockheaderWeb3-Community/cohort-6/blob/main/assignments/Assignment3.md]
PR Checklist