-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Satochip NFC Hardware wallet support #251
base: master
Are you sure you want to change the base?
Conversation
App activity is required for NfcAdapter to send apdu commands to the card. Use Koin framework for this...
Scan card + list card + create SatochipDevice
add SatochipHWWallet.java
Also simplify nfc scan in DeviceConnectionManagerAndroid
Allows to easily add support for additional NFC devices...
TODO: some configuration is required to actually add the translation in the app...
# Conflicts: # common/src/commonMain/kotlin/com/blockstream/common/data/ErrorReport.kt
Video context - easy to setup: Satochip x Green Wallet - Pair the hardware wallet over NFC Satochip x Green Wallet - Sign a transaction over NFC |
@Bastien-Satochip can you set us up with some devices so we can test too? |
Hey 👋
Yeah sure of course!
How can I reach you?
|
|
Mail sent. Thank you! |
FYI, we have added support for Liquid-Bitcoin in Satochip latest beta firmware, and updated the pull request. |
@Toporin we are undergoing a large refactoring of the UI, we won't be able to test this properly for a bit. I will keep you up to date on our progress so that you can rebase your implementation once we are done |
@domegabri : did you receive my mail? |
This is a pull request to add support for the Satochip hardware wallet.
The Satochip hardware wallet is based on a jacavard smartcard and is fully open-source.
The firmware uses a javacard applet that is loaded on the smartcard.
With native NFC (Near Field Communication) support, Satochip enables seamless interaction with mobile devices.
Satochip technical details
Advantages of Satochip
Here are the main advantages of the Satochip hardware wallet:
NFC Support
Hardware wallets have become the gold standard for securing Bitcoin, but they often lack mobile-friendliness, making everyday transactions cumbersome. NFC technology can bridge this gap and improve Bitcoin adoption by enhancing convenience without compromising security.
There are a few players in the Bitcoin hardware wallet NFC field such as:
We tried to implement NFC integration in a simple and flexible way, making it easy to support additional NFC devices in the future. We are available to collaborate and ensure a smooth integration process while aligning with your standards. We are happy to discuss any aspects of the implementation, including UI considerations, integration details, or potential modifications, to make sure this solution fits seamlessly into Green Wallet. We can also provide samples for testing. Let us know how we can assist!
More info:
https://github.com/Toporin/ (Official repository)
https://x.com/satochip (X account)
https://t.me/Satochip (Telegram support)