Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix READEME #8

Open
BlakeKaufman opened this issue Feb 4, 2025 · 1 comment
Open

fix READEME #8

BlakeKaufman opened this issue Feb 4, 2025 · 1 comment

Comments

@BlakeKaufman
Copy link
Contributor

The get transaction variable should be changed from

const address = await wollet.getTransactions();
console.log(address);

to

const transactions = await wollet.getTransactions();
console.log(transactions);

The txid string returned from a sent transaction should be changed from

 console.log("BROADCASTED TX!\nTXID: {:?}", tx.txId.toString());

to

 console.log("BROADCASTED TX!\nTXID: {:?}", (await tx.txId()).toString());

Also, we might want to add documentation saying you need to add in the android > build.gradle as well as the minSdkVersion being 24

allprojects {
    repositories {
        // * Your other repositories here *
        maven {
            name = "GitHubPackages"
            url = uri("https://maven.pkg.github.com/blockstream/lwk")
            // * Github personal access token *
            credentials { 
                username = System.getenv("GITHUB_USER")
                password = System.getenv("GITHUB_TOKEN")
            }
        }
    }
}
@lvaccaro lvaccaro mentioned this issue Mar 6, 2025
@lvaccaro
Copy link
Member

lvaccaro commented Mar 6, 2025

sorry to be late, thanks to report these issues.
Open MR9 and feel free to add feedbacks and comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants