SQL Alchemy / Heroku compatability #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagelface
reviewed
Feb 17, 2025
| db_url = os.getenv("DATABASE_URL") | ||
| if db_url.startswith("postgres://"): | ||
| db_url = db_url.replace("postgres://", "postgresql://", 1) | ||
| return db_url |
There was a problem hiding this comment.
couldn't we just do:
if os.getenv("DATABASE_URL"):
return os.getenv("DATABASE_URL").replace("postgres://", "postgresql://", 1)There was a problem hiding this comment.
also why did we drop the +psycopg2 part?
bagelface
reviewed
Feb 17, 2025
|
|
||
| await discord_client.start(settings.DISCORD_BOT_TOKEN) | ||
|
|
||
| await discord_client.wait_until_ready() | ||
| await asyncio.Future() |
There was a problem hiding this comment.
what purpose does this serve?
bagelface
reviewed
Feb 17, 2025
| from src.infrastructure.config.settings import load_environment, Settings | ||
| from src.infrastructure.notion_client.client import NotionClient | ||
| from src.infrastructure.discord_client.client import DiscordClient | ||
| from src.domain.notion.repositories import SQLNotionRepository | ||
| from src.application.notion.notion_service import NotionService | ||
| from src.application.discord.discord_service import DiscordService | ||
| from src.scripts.init_db import init_db |
There was a problem hiding this comment.
would prefer to see this "init_db" functionality added as like a utility or something and then imported into the "scripts/init_db.py" file instead of the other way around
bagelface
reviewed
Feb 17, 2025
| user_model = NotionUserModel( | ||
| id=user.id, name=user.name or "Unknown User", avatar_url=user.avatar_url | ||
| ) | ||
| session.add(user_model) |
There was a problem hiding this comment.
do we need to commit after this?
|
Closing PR. I was encountering an error locally to try and replicate and issue that Bagel was having with deploying the changes to Heroku (staging). This has since been resolved and as such these changes are unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes error when checking for new creations / update