Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support content_type when downloading #265

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Conversation

MFSY
Copy link
Collaborator

@MFSY MFSY commented Aug 16, 2022

  • Support downloading data of a given content-type
  • When downloading, set the default json property path to follow to "distribution.contentUrl" in order to get the
    downloadable file urls and the default download path to the current folder
  • Disable rewriting following SPARQL keywords: "as", "not", "exists", "group", "by"
  • Updated SPARQL query statement builder to consider @id and @type values as URIs when used with the NOT_EQUAL operator
  • Added methods to check if a Resource has an identifier or a type and added methods to get them

Fixes #251

MFSY added 2 commits August 16, 2022 18:51
* Disable rewriting following SPARQL keywords: "as", "not", "exists", "group", "by"
* Updated SPARQL query statement builder to consider @id and @type values as URIs when used with the NOT_EQUAL operator
* Added methods to  check if a Resource has an identifier or a type and added methods to get them
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #265 (f076e78) into master (9a04477) will decrease coverage by 0.31%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   72.57%   72.25%   -0.32%     
==========================================
  Files          86       86              
  Lines        5341     5374      +33     
==========================================
+ Hits         3876     3883       +7     
- Misses       1465     1491      +26     
Impacted Files Coverage Δ
kgforge/core/archetypes/store.py 62.24% <0.00%> (ø)
kgforge/core/forge.py 70.05% <0.00%> (ø)
kgforge/specializations/stores/bluebrain_nexus.py 27.57% <20.00%> (-0.14%) ⬇️
kgforge/core/resource.py 71.59% <21.73%> (-17.81%) ⬇️
kgforge/core/commons/dictionaries.py 72.72% <40.00%> (-27.28%) ⬇️
kgforge/specializations/resources/datasets.py 67.41% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crisely09 crisely09 force-pushed the download_with_content_type branch from dc29ece to 829c6df Compare November 15, 2022 14:20
@MFSY MFSY force-pushed the download_with_content_type branch from c637d1f to 349311f Compare March 29, 2023 10:59
@crisely09
Copy link
Contributor

Looks good to me.

@MFSY MFSY merged commit 96665b6 into master Mar 29, 2023
@MFSY MFSY deleted the download_with_content_type branch March 29, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support content_type when calling forge.download and Dataset.download
3 participants