Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zrok proxy issue in BlueBubbles server #705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cameronaaron
Copy link
Contributor

@cameronaaron cameronaaron commented Nov 13, 2024

Fixes #678

Fix the Zrok proxy issue by adding logic to handle errors and restart the proxy.

  • packages/server/src/server/api/http/api/v1/socketRoutes.ts

    • Import ZrokService.
    • Add logic to handle the Zrok proxy issue by disabling and re-enabling the Zrok proxy if an error is detected.
    • Update the change-proxy-service event to include the new logic.
  • packages/server/src/server/managers/zrokManager/index.ts

    • Add logic to handle the error where the server address remains unchanged by attempting to disable and re-enable the Zrok proxy.
    • Update the connectHandler method to include the new logic.
    • Implement handleError method to handle errors and restart the Zrok proxy.
  • packages/server/src/server/services/proxyServices/zrokService/index.ts

    • Implement a check for the error and attempt to disable and re-enable the Zrok proxy if the error is detected.
    • Update the connect method to include the new logic.

Fixes BlueBubblesApp#678

Fix the Zrok proxy issue by adding logic to handle errors and restart the proxy.

* **packages/server/src/server/api/http/api/v1/socketRoutes.ts**
  - Import `ZrokService`.
  - Add logic to handle the Zrok proxy issue by disabling and re-enabling the Zrok proxy if an error is detected.
  - Update the `change-proxy-service` event to include the new logic.

* **packages/server/src/server/managers/zrokManager/index.ts**
  - Add logic to handle the error where the server address remains unchanged by attempting to disable and re-enable the Zrok proxy.
  - Update the `connectHandler` method to include the new logic.
  - Implement `handleError` method to handle errors and restart the Zrok proxy.

* **packages/server/src/server/services/proxyServices/zrokService/index.ts**
  - Implement a check for the error and attempt to disable and re-enable the Zrok proxy if the error is detected.
  - Update the `connect` method to include the new logic.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/BlueBubblesApp/bluebubbles-server/issues/678?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zrok implementation not working
1 participant