-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve zug #2
Improve zug #2
Conversation
Signed-off-by: Uilian Ries <[email protected]>
Thanks a lot for all the great improvements :-)
def package_id(self):
self.info.header_only() but maybe it's best to be explicit in that this package only depends on the compiler and std? |
Signed-off-by: Uilian Ries <[email protected]>
|
|
About patch example, there are tons in Conan Center Index, just search for "patches". Anyway, it's documented here and here |
I understand patching the library code if we can't change it, but AFAIK this is not the issue here. def package_info(self):
if is_msvc(self):
self.cpp_info.cxxflags = ["/Zc:externConstexpr"] What other way does the library have which can be taken by the recipe and put in the package so a client can import the package? The link you put, tells the programmer to add this flag manually to his build script which uses Zug. |
btw, about settings: https://github.com/conan-io/conan-center-index/blob/154c9edca773d52a790d917bf2c0b95796a7ce7b/docs/packaging_policy.md#settings
https://docs.conan.io/en/latest/reference/conanfile/methods.html#cpp-info You already did. When passing |
* [Catch2] adapt recipe for Conan v2 * fixes * fixes * fixes * fixes * fixes 4 * fixes 5 * fixes 6 * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <[email protected]> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <[email protected]> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <[email protected]> * Update recipes/catch2/3.x.x/conanfile.py * fix patches * fix * fix * remove comments * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Chris Mc <[email protected]> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Chris Mc <[email protected]> * test package changes * Move test package files (#2) * move gtest Signed-off-by: Uilian Ries <[email protected]> * Delete test_all.sh * Use cmake targets * Do not use settings Signed-off-by: Uilian Ries <[email protected]> Signed-off-by: Uilian Ries <[email protected]> Co-authored-by: Uilian Ries <[email protected]> Co-authored-by: Chris Mc <[email protected]>
* sqlcipher: Add 4.5.6 * sqlcipher: Add 4.5.6 * sqlcipher: Fix topic case and add missing endline * sqlcipher: Fix license for version >4.5.6 * do not enforce cmake in test package Signed-off-by: Uilian Ries <[email protected]> * sqlcipher: relax license filename to copy Co-authored-by: Uilian Ries <[email protected]> * sqlcipher: Add option to enable column metadata * sqlcipher: do not enforce cmake in test package #2 --------- Signed-off-by: Uilian Ries <[email protected]> Co-authored-by: Uilian Ries <[email protected]>
Some improvements to accept your recipe in Conan Center Index