Bianca/deepclimb 4645 y25 67#12
Open
bsverdin wants to merge 39 commits into
Open
Conversation
…ogs4645/SY2025-CORE-A into bianca/deepclimb-4645Y25-67
…work, can someone review my code)
…work, can someone review my code)
camden-git
suggested changes
Feb 23, 2025
Contributor
camden-git
left a comment
camden-git
left a comment
There was a problem hiding this comment.
There are still a few changes needed, check my comments. I tried to make more specific comments rather than less general comments. I made all of these comments assuming that this code is tested working, if that isn't the case let me know and I can focus on that.
Thanks
Author
|
Ok, I believe I fixed everything, but if not just let me know. Thank you! |
camden-git
suggested changes
Feb 25, 2025
Contributor
camden-git
left a comment
camden-git
left a comment
There was a problem hiding this comment.
I left like two more things, shouldn't take longer then 10 minutes
Contributor
|
LGTM, has this code been tested? |
Author
|
I have tested this code before on our wood prototype, but haven't tested on the chute on the robot. Tomorrow, during my Robotics Class, I can test the chute on the robot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stow completed for Scrimmage